CDJ11/CDJ

File debate_spec.rb has 590 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

describe Debate do
  let(:debate) { build(:debate) }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "reorder" do

      it "is able to reorder by hot_score after searching" do
        lowest_score  = create(:debate,  title: 'stop corruption', cached_votes_up: 1)
        highest_score = create(:debate,  title: 'stop corruption', cached_votes_up: 2)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "cache" do
    let(:debate) { create(:debate) }

    it "expires cache when it has a new comment" do
      expect { create(:comment, commentable: debate) }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#editable?" do
    let(:debate) { create(:debate) }

    before { Setting["max_votes_for_debate_edit"] = 3 }
    after { Setting["max_votes_for_debate_edit"] = 1000 }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "returns debates ordered by cached_votes_total" do
      debate1 =  create(:debate, cached_votes_total: 1, tag_list: "Sport")
      debate2 =  create(:debate, cached_votes_total: 5, tag_list: "Sport")
      debate3 =  create(:debate, cached_votes_total: 10, tag_list: "Sport")
      proposal = create(:proposal, tag_list: "Sport")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "orders by weight and then votes" do
        title_some_votes    = create(:debate, title: 'stop corruption', cached_votes_up: 5)
        title_least_voted   = create(:debate, title: 'stop corruption', cached_votes_up: 2)
        title_most_voted    = create(:debate, title: 'stop corruption', cached_votes_up: 10)
        description_most_voted = create(:debate, description: 'stop corruption', cached_votes_up: 10)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "accents" do

      it "searches with accents" do
        debate = create(:debate, title: 'difusión')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#tag_list" do
    it "sanitizes the tag list" do
      debate.tag_list = "user_id=1"
      debate.valid?
      expect(debate.tag_list).to eq(['user_id1'])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "does not return debates when user is the author" do
      debate1 =  create(:debate, author: user, tag_list: "Sport")
      debate2 =  create(:debate, tag_list: "Sport")
      proposal = create(:proposal, tag_list: "Sport")
      create(:follow, followable: proposal, user: user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "custom tag counters when hiding/restoring" do
    it "decreases the tag counter when hiden, and increases it when restored" do
      debate = create(:debate, tag_list: "foo")
      tag = ActsAsTaggableOn::Tag.where(name: 'foo').first
      expect(tag.debates_count).to eq(1)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "returns debates related with user interests" do
      debate1 =  create(:debate, tag_list: "Sport")
      debate2 =  create(:debate, tag_list: "Politics")
      proposal1 = create(:proposal, tag_list: "Sport")
      create(:follow, followable: proposal1, user: user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "stemming" do

      it "searches word stems" do
        debate = create(:debate, title: 'limpiar')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "case" do
      it "searches case insensite" do
        debate = create(:debate, title: 'SHOUT')

        results = described_class.search('shout')

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

  describe "#title" do
    it "is not valid without a title" do
      debate.title = nil
      expect(debate).not_to be_valid
    end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "gives much more weight to word matches than votes" do
        exact_title_few_votes    = create(:debate, title: 'stop corruption', cached_votes_up: 5)
        similar_title_many_votes = create(:debate, title: 'stop some of the corruption', cached_votes_up: 500)

        results = described_class.search('stop corruption')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "increases for debates with more confidence" do
      more_confidence = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 1000, cached_votes_up: 700)
      less_confidence = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 9)
      expect(more_confidence.hot_score).to be > less_confidence.hot_score

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "increases for debates with more positive votes" do
      more_likes = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 5)
      less_likes = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 1)
      expect(more_likes.hot_score).to be > less_likes.hot_score

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    context "tags" do
      it "searches by tags" do
        debate = create(:debate, tag_list: 'Latina')

        results = described_class.search('Latina')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe 'public_for_api scope' do
    it 'returns debates' do
      debate = create(:debate)
      expect(described_class.public_for_api).to include(debate)
    end

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it "increases for debates with more comments" do
      more_comments = create(:debate, :with_hot_score, created_at: now, comments_count: 25)
      less_comments = create(:debate, :with_hot_score, created_at: now, comments_count: 1)
      expect(more_comments.hot_score).to be > less_comments.hot_score

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "increases for newer debates" do
      old = create(:debate, :with_hot_score, created_at: now - 1.day)
      new = create(:debate, :with_hot_score, created_at: now)
      expect(new.hot_score).to be > old.hot_score

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "increases with comments" do
        previous = debate.hot_score
        25.times{ Comment.create(user: create(:user), commentable: debate, body: 'foobarbaz') }
        expect(previous).to be < debate.reload.hot_score

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "registers vote" do
        user = create(:user, residence_verified_at: Time.current, confirmed_phone: "666333111")
        expect {debate.register_vote(user, 'yes')}.to change{debate.reload.votes_for.size}.by(1)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "decreases with dislikes" do
        debate.register_vote(create(:user), true)
        previous = debate.confidence_score
        3.times { debate.register_vote(create(:user), false) }
        expect(previous).to be > debate.confidence_score

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "decreases with dislikes" do
        debate.register_vote(create(:user), true)
        previous = debate.hot_score
        3.times { debate.register_vote(create(:user), false) }
        expect(previous).to be > debate.hot_score

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

      it "searches by geozone" do
        geozone = create(:geozone, name: 'California')
        debate = create(:debate, geozone: geozone)
        results = described_class.search('California')
        expect(results).to eq([debate])

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

      it "searches by author name" do
        author = create(:user, username: 'Danny Trejo')
        debate = create(:debate, author: author)
        results = described_class.search('Danny')
        expect(results).to eq([debate])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "registers vote" do
        user = create(:user, verified_at: Time.current)
        expect {debate.register_vote(user, 'yes')}.to change{debate.reload.votes_for.size}.by(1)

• Read up
  Read up

Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      more_likes = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 5)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate = create(:debate, :with_confidence_score, cached_votes_up: 750, cached_votes_total: 1000)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [131/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      older_more_voted = create(:debate, :with_hot_score, created_at: now - 5.days, cached_votes_total: 1000, cached_votes_up: 900)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [126/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate = create(:debate, :with_confidence_score, cached_votes_up: 100, cached_votes_score: 100, cached_votes_total: 100)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        recent  = create(:debate,  title: 'stop corruption', cached_votes_up: 1, created_at: 1.week.ago)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        least_commented = create(:debate,  title: 'stop corruption',  cached_votes_up: 1, comments_count: 1)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        description_most_voted = create(:debate, description: 'stop corruption', cached_votes_up: 10)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [122/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate.tag_list = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa", "Huelgas"]

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [117/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      less_confidence = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 9)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        expect {debate.register_vote(user, 'yes')}.to change {debate.reload.cached_anonymous_votes_total}.by(1)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [121/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      more_confidence = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 1000, cached_votes_up: 700)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        expect {debate.register_vote(user, 'yes')}.not_to change{debate.reload.cached_anonymous_votes_total}

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        newest  = create(:debate,  title: 'stop corruption', cached_votes_up: 2, created_at: Time.current)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        oldest  = create(:debate,  title: 'stop corruption', cached_votes_up: 3, created_at: 1.month.ago)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      less_likes = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 1)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      new_less_voted   = create(:debate, :with_hot_score, created_at: now, cached_votes_total: 10, cached_votes_up: 9)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        most_commented  = create(:debate,  title: 'stop corruption',  cached_votes_up: 2, comments_count: 100)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        expect {debate.register_vote(user, 'yes')}.not_to change{debate.reload.cached_anonymous_votes_total}

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        expect {debate.register_vote(user, 'yes')}.not_to change {debate.reload.cached_anonymous_votes_total}

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        similar_title_many_votes = create(:debate, title: 'stop some of the corruption', cached_votes_up: 500)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        some_comments   = create(:debate,  title: 'stop corruption',  cached_votes_up: 3, comments_count: 10)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate.tag_list = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa"]

• Exclude checks
  • Disable engine
  • Disable check