Method has too many lines. [60/30] Open
def read_question(node)
question_item = @instrument.question_items.new(
label: node['name'],
literal: node.at_xpath('./qt_properties/label')&.content
)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method read_question
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
def read_question(node)
question_item = @instrument.question_items.new(
label: node['name'],
literal: node.at_xpath('./qt_properties/label')&.content
)
- Create a ticketCreate a ticket
Cyclomatic complexity for read_question is too high. [11/6] Open
def read_question(node)
question_item = @instrument.question_items.new(
label: node['name'],
literal: node.at_xpath('./qt_properties/label')&.content
)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method read_question
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def read_question(node)
question_item = @instrument.question_items.new(
label: node['name'],
literal: node.at_xpath('./qt_properties/label')&.content
)
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Unused method argument - args
. If it's necessary, use _
or _args
as an argument name to indicate that it won't be used. Open
def method_missing(m, *args, &block)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks for unused method arguments.
Example:
# bad
def some_method(used, unused, _unused_but_allowed)
puts used
end
Example:
# good
def some_method(used, _unused, _unused_but_allowed)
puts used
end
Unused method argument - block
. If it's necessary, use _
or _block
as an argument name to indicate that it won't be used. Open
def method_missing(m, *args, &block)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks for unused method arguments.
Example:
# bad
def some_method(used, unused, _unused_but_allowed)
puts used
end
Example:
# good
def some_method(used, _unused, _unused_but_allowed)
puts used
end