Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java

Summary

Maintainability
A
1 hr
Test Coverage
A
92%

Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    @Override
    public void run(Bootstrap<?> bootstrap, Namespace namespace) throws Exception {
        final IdType orgID = new IdType(namespace.getString("org-reference"));
        final String apiService = namespace.getString(API_HOSTNAME);
        System.out.println(String.format("Connecting to API service at: %s", apiService));
Severity: Minor
Found in dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java - About 1 hr to fix

    Replace this use of System.out or System.err by a logger.
    Open

                    System.out.println(String.format("Organization token: %s", token));
    Severity: Major
    Found in dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java by sonar-java

    When logging a message there are several important requirements which must be fulfilled:

    • The user must be able to easily retrieve the logs
    • The format of all logged message must be uniform to allow the user to easily read the log
    • Logged data must actually be recorded
    • Sensitive data must only be logged securely

    If a program directly writes to the standard outputs, there is absolutely no way to comply with those requirements. That's why defining and using a dedicated logger is highly recommended.

    Noncompliant Code Example

    System.out.println("My Message");  // Noncompliant

    Compliant Solution

    logger.log("My Message");

    See

    Replace this use of System.out or System.err by a logger.
    Open

            System.out.println(String.format("Connecting to API service at: %s", apiService));
    Severity: Major
    Found in dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java by sonar-java

    When logging a message there are several important requirements which must be fulfilled:

    • The user must be able to easily retrieve the logs
    • The format of all logged message must be uniform to allow the user to easily read the log
    • Logged data must actually be recorded
    • Sensitive data must only be logged securely

    If a program directly writes to the standard outputs, there is absolutely no way to comply with those requirements. That's why defining and using a dedicated logger is highly recommended.

    Noncompliant Code Example

    System.out.println("My Message");  // Noncompliant

    Compliant Solution

    logger.log("My Message");

    See

    Replace this use of System.out or System.err by a logger.
    Open

                        System.err.println("Error fetching organization: " + response.getStatusLine().getReasonPhrase());
    Severity: Major
    Found in dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java by sonar-java

    When logging a message there are several important requirements which must be fulfilled:

    • The user must be able to easily retrieve the logs
    • The format of all logged message must be uniform to allow the user to easily read the log
    • Logged data must actually be recorded
    • Sensitive data must only be logged securely

    If a program directly writes to the standard outputs, there is absolutely no way to comply with those requirements. That's why defining and using a dedicated logger is highly recommended.

    Noncompliant Code Example

    System.out.println("My Message");  // Noncompliant

    Compliant Solution

    logger.log("My Message");

    See

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                try (CloseableHttpResponse response = httpClient.execute(post)) {
                if (!HttpStatus.isSuccess(response.getStatusLine().getStatusCode())) {
                    System.err.println("Error fetching organization: " + response.getStatusLine().getReasonPhrase());
                    System.exit(1);
                }
    Severity: Major
    Found in dpc-api/src/main/java/gov/cms/dpc/api/cli/tokens/TokenCreate.java and 1 other location - About 1 hr to fix
    dpc-api/src/main/java/gov/cms/dpc/api/cli/keys/KeyUpload.java on lines 100..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status