Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java

Summary

Maintainability
A
2 hrs
Test Coverage
A
92%

File PatientResource.java has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package gov.cms.dpc.api.resources.v1;

import ca.uhn.fhir.rest.api.MethodOutcome;
import ca.uhn.fhir.rest.client.api.IGenericClient;
import ca.uhn.fhir.validation.FhirValidator;
Severity: Minor
Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java - About 2 hrs to fix

    Method everything has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @GET
    @FHIR
    @Path("/{patientID}/$everything")
    @PathAuthorizer(type = DPCResourceType.Patient, pathParam = "patientID")
    @Timed
    Severity: Minor
    Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java - About 1 hr to fix

      Method everything has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public Bundle everything(@ApiParam(hidden = true) @Auth OrganizationPrincipal organization,
                             @Valid @Profiled @ProvenanceHeader Provenance provenance,
                             @ApiParam(value = "Patient resource ID", required = true) @PathParam("patientID") UUID patientId,
                             @QueryParam("_since") @NoHtml String sinceParam,
                             @Context HttpServletRequest request) {
      Severity: Minor
      Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java - About 35 mins to fix

        Merge this if statement with the enclosing one.
        Open

                    if (result.getMessages().get(0).getSeverity() != ResultSeverityEnum.INFORMATION) {
        Severity: Major
        Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java by sonar-java

        Merging collapsible if statements increases the code's readability.

        Noncompliant Code Example

        if (file != null) {
  if (file.isFile() || file.isDirectory()) {
    /* ... */
  }
}

        Compliant Solution

        if (file != null && isFileOrDirectory(file)) {
  /* ... */
}

private static boolean isFileOrDirectory(File file) {
  return file.isFile() || file.isDirectory();
}

        Similar blocks of code found in 5 locations. Consider refactoring.
        Invalid

            @Inject
    public PatientResource(@Named("attribution") IGenericClient client, FhirValidator validator, DataService dataService, BlueButtonClient bfdClient) {
        this.client = client;
        this.validator = validator;
        this.dataService = dataService;
        Severity: Major
        Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/PatientResource.java and 4 other locations - About 45 mins to fix
        dpc-aggregation/src/main/java/gov/cms/dpc/aggregation/engine/AggregationEngine.java on lines 58..64
        dpc-api/src/main/java/gov/cms/dpc/api/auth/DPCAuthFactory.java on lines 21..27
        dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/OrganizationResource.java on lines 49..55
        dpc-queue/src/main/java/gov/cms/dpc/queue/service/DataService.java on lines 42..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status