Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
lambda/opt-out-import/db.go

Summary

Maintainability
A
1 hr
Test Coverage

Function getAssumeRoleArn has 6 return statements (exceeds 4 allowed).
Open

func getAssumeRoleArn() (string, error) {
    if isTesting {
        val := os.Getenv("AWS_ASSUME_ROLE_ARN")
        if val == "" {
            return "", fmt.Errorf("AWS_ASSUME_ROLE_ARN must be set during testing")
Severity: Major
Found in lambda/opt-out-import/db.go - About 40 mins to fix

    Function insertConsentRecords has 5 return statements (exceeds 4 allowed).
    Open

    func insertConsentRecords(db *sql.DB, optOutFileId string, records []*OptOutRecord) ([]*OptOutRecord, error) {
    createdRecords := []*OptOutRecord{}

    // If there aren't any rows, skip this and update the import_status of the file
    if len(records) > 0 {
    Severity: Major
    Found in lambda/opt-out-import/db.go - About 35 mins to fix

      Function insertConsentRecords has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func insertConsentRecords(db *sql.DB, optOutFileId string, records []*OptOutRecord) ([]*OptOutRecord, error) {
    createdRecords := []*OptOutRecord{}

    // If there aren't any rows, skip this and update the import_status of the file
    if len(records) > 0 {
      Severity: Minor
      Found in lambda/opt-out-import/db.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status