Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
lambda/opt-out-import/main.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function importResponseFile has 78 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func importResponseFile(bucket string, file string) (int, int, string, error) {
    log.Infof("Importing opt out file: %s (bucket: %s)", file, bucket)
    metadata, err := ParseMetadata(bucket, file)
    if err != nil {
        log.Warningf("Failed to parse opt out file metadata: %s", err)
Severity: Major
Found in lambda/opt-out-import/main.go - About 2 hrs to fix

    Function importResponseFile has 14 return statements (exceeds 4 allowed).
    Open

    func importResponseFile(bucket string, file string) (int, int, string, error) {
    log.Infof("Importing opt out file: %s (bucket: %s)", file, bucket)
    metadata, err := ParseMetadata(bucket, file)
    if err != nil {
        log.Warningf("Failed to parse opt out file metadata: %s", err)
    Severity: Major
    Found in lambda/opt-out-import/main.go - About 1 hr to fix

      Function handler has 5 return statements (exceeds 4 allowed).
      Open

      func handler(ctx context.Context, sqsEvent events.SQSEvent) (string, error) {
    log.SetFormatter(&log.JSONFormatter{
        DisableHTMLEscape: true,
        TimestampFormat:   time.RFC3339Nano,
    })
      Severity: Major
      Found in lambda/opt-out-import/main.go - About 35 mins to fix

        Function importResponseFile has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func importResponseFile(bucket string, file string) (int, int, string, error) {
    log.Infof("Importing opt out file: %s (bucket: %s)", file, bucket)
    metadata, err := ParseMetadata(bucket, file)
    if err != nil {
        log.Warningf("Failed to parse opt out file metadata: %s", err)
        Severity: Minor
        Found in lambda/opt-out-import/main.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status