CORE-POS/Common-Bundle

View on GitHub
src/sql/SqliteAdapter.php

Summary

Maintainability
A
2 hrs
Test Coverage

The class SqliteAdapter has 19 public methods. Consider refactoring SqliteAdapter to keep number of public methods under 10.
Open

class SqliteAdapter implements DialectAdapter
{
    public function createNamedDB($name)
    {
        return 'SELECT 1';
Severity: Minor
Found in src/sql/SqliteAdapter.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

SqliteAdapter has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class SqliteAdapter implements DialectAdapter
{
    public function createNamedDB($name)
    {
        return 'SELECT 1';
Severity: Minor
Found in src/sql/SqliteAdapter.php - About 2 hrs to fix

    Avoid unused parameters such as '$name'.
    Open

        public function useNamedDB($name)
    Severity: Minor
    Found in src/sql/SqliteAdapter.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$charset'.
    Open

        public function setCharSet($charset)
    Severity: Minor
    Found in src/sql/SqliteAdapter.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$name'.
    Open

        public function createNamedDB($name)
    Severity: Minor
    Found in src/sql/SqliteAdapter.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    There are no issues that match your filters.

    Category
    Status