CORE-POS/IS4C

View on GitHub
fannie/admin/LookupReceipt/ReprintReceiptPage.php

Summary

Maintainability
D
1 day
Test Coverage
F
50%

Method get_date_handler has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function get_date_handler()
    {
        $date = $this->date;
        $date2 = FormLib::get('date2','');
        if ($date === '' && $date2 !== '') {
Severity: Major
Found in fannie/admin/LookupReceipt/ReprintReceiptPage.php - About 5 hrs to fix

    Function get_date_handler has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        function get_date_handler()
        {
            $date = $this->date;
            $date2 = FormLib::get('date2','');
            if ($date === '' && $date2 !== '') {
    Severity: Minor
    Found in fannie/admin/LookupReceipt/ReprintReceiptPage.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ReprintReceiptPage.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*******************************************************************************
    
        Copyright 2009 Whole Foods Co-op
    
    
    Severity: Minor
    Found in fannie/admin/LookupReceipt/ReprintReceiptPage.php - About 2 hrs to fix

      Method toTable has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function toTable($dbc, $result, $dlog)
          {
              $this->addScript('../../src/javascript/tablesorter/jquery.tablesorter.js');
              $this->addOnloadCommand("\$('.tablesorter').tablesorter();\n");
              $ret = "<b>Matching receipts</b>:<br />";
      Severity: Major
      Found in fannie/admin/LookupReceipt/ReprintReceiptPage.php - About 2 hrs to fix

        There are no issues that match your filters.

        Category
        Status