Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/admin/ReceiptText/LaneTextStringPage.php

Summary

Maintainability
B
4 hrs
Test Coverage
B
89%

Method post_id_line_type_handler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_id_line_type_handler()
    {
        $this->connection->selectDB($this->config->get('OP_DB'));
        $model = new CustomReceiptModel($this->connection);
        $model->type($this->type);
Severity: Minor
Found in fannie/admin/ReceiptText/LaneTextStringPage.php - About 1 hr to fix

    Method get_view has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_view()
    {
        $this->addScript('lane-text.js');
        $opts = '';
        foreach ($this->TRANSLATE as $short=>$long) {
    Severity: Minor
    Found in fannie/admin/ReceiptText/LaneTextStringPage.php - About 1 hr to fix

      Method get_type_handler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_type_handler()
    {
        if ($this->type == '') {
            echo '';
            return false;
      Severity: Minor
      Found in fannie/admin/ReceiptText/LaneTextStringPage.php - About 1 hr to fix

        Function post_id_line_type_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function post_id_line_type_handler()
    {
        $this->connection->selectDB($this->config->get('OP_DB'));
        $model = new CustomReceiptModel($this->connection);
        $model->type($this->type);
        Severity: Minor
        Found in fannie/admin/ReceiptText/LaneTextStringPage.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status