Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/admin/labels/PickTagsPage.php

Summary

Maintainability
D
2 days
Test Coverage
F
29%

Function post_id_handler has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function post_id_handler()
    {
        $shelfLife = FormLib::get('shelfLife', false);
        list($inStr, $args) = $this->connection->safeInClause($this->id);
        $map = array();
Severity: Minor
Found in fannie/admin/labels/PickTagsPage.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post_id_handler has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_id_handler()
    {
        $shelfLife = FormLib::get('shelfLife', false);
        list($inStr, $args) = $this->connection->safeInClause($this->id);
        $map = array();
Severity: Major
Found in fannie/admin/labels/PickTagsPage.php - About 3 hrs to fix

    File PickTagsPage.php has 265 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

use COREPOS\Fannie\API\item\signage\Tags4x8P;
use COREPOS\Fannie\API\lib\Store;
    Severity: Minor
    Found in fannie/admin/labels/PickTagsPage.php - About 2 hrs to fix

      Method ordersToItems has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function ordersToItems()
    {
        $orders = FormLib::get('oid', array());
        $priced = FormLib::get('priced', false);
        list($inStr, $args) = $this->connection->safeInClause($orders);
      Severity: Major
      Found in fannie/admin/labels/PickTagsPage.php - About 2 hrs to fix

        Method post_u_view has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function post_u_view()
    {
        list($inStr, $args) = $this->connection->safeInClause($this->u);
        $simpP = $this->connection->prepare("
            SELECT upc, brand, description
        Severity: Minor
        Found in fannie/admin/labels/PickTagsPage.php - About 1 hr to fix

          Function ordersToItems has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function ordersToItems()
    {
        $orders = FormLib::get('oid', array());
        $priced = FormLib::get('priced', false);
        list($inStr, $args) = $this->connection->safeInClause($orders);
          Severity: Minor
          Found in fannie/admin/labels/PickTagsPage.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method purchaseOrderList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function purchaseOrderList()
    {
        $store = Store::getIdByIp(0);
        $prep = $this->connection->prepare("
            SELECT p.orderID,
          Severity: Minor
          Found in fannie/admin/labels/PickTagsPage.php - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (substr($item['upc'], 0, 3) == '002') {
                    $right = sprintf('%.2f', $row['normal_price']);
                    $right = str_replace('.', '', $right);
                    $right = str_pad($right, 4, '0', STR_PAD_LEFT);
                    $item['upc'] = substr($item['upc'], 0, 9) . $right;
            Severity: Major
            Found in fannie/admin/labels/PickTagsPage.php and 1 other location - About 2 hrs to fix
            fannie/admin/labels/PickTagsPage.php on lines 78..83

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (substr($item['upc'], 0, 3) == '002') {
                    $right = sprintf('%.2f', $itemW['normal_price']);
                    $right = str_replace('.', '', $right);
                    $right = str_pad($right, 4, '0', STR_PAD_LEFT);
                    $item['upc'] = substr($item['upc'], 0, 9) . $right;
            Severity: Major
            Found in fannie/admin/labels/PickTagsPage.php and 1 other location - About 2 hrs to fix
            fannie/admin/labels/PickTagsPage.php on lines 163..168

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        $item = array(
                'upc' => $row['internalUPC'],
                'description' => $row['description'],
                'posDescription' => $row['description'],
                'brand' => $row['brand'],
            Severity: Minor
            Found in fannie/admin/labels/PickTagsPage.php and 1 other location - About 1 hr to fix
            fannie/purchasing/exporters/ReceivingTagsExport.php on lines 63..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status