Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php

Summary

Maintainability
C
1 day
Test Coverage
C
74%

Method generateSoupTag has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateSoupTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc)
{
    $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
    $upc = $row['upc'];
    $brand = $row['description'];
Severity: Major
Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 2 hrs to fix

    Method Soup_Signs_4UP has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Soup_Signs_4UP($data,$offset=0)
{
    $dbc = FannieDB::get(FannieConfig::config('OP_DB'));
    $pdf = new Soup_Signs_4UP_PDF('L','mm','Letter');
    $pdf->AddPage();
    Severity: Minor
    Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 1 hr to fix

      Function Soup_Signs_4UP has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function Soup_Signs_4UP($data,$offset=0)
{
    $dbc = FannieDB::get(FannieConfig::config('OP_DB'));
    $pdf = new Soup_Signs_4UP_PDF('L','mm','Letter');
    $pdf->AddPage();
      Severity: Minor
      Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generateSoupTag has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function generateSoupTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc)
      Severity: Major
      Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 1 hr to fix

        Method barcodeText has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function barcodeText($x, $y, $h, $barcode, $len)
        Severity: Minor
        Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 35 mins to fix

          Function generateSoupTag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function generateSoupTag($x, $y, $guide, $width, $height, $pdf, $row, $dbc)
{
    $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
    $upc = $row['upc'];
    $brand = $row['description'];
          Severity: Minor
          Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($i == 0) {
            $pdf = generateSoupTag($x, $y, $guide, $width*2, $height*3, $pdf, $row, $dbc);
        } else if ($i % 2 == 0 && $i != 0) {
            $x = $left*2+$guide -3;
            $y += $height*3+$guide;
          Severity: Major
          Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php and 1 other location - About 2 hrs to fix
          fannie/admin/labels/pdf_layouts/Cheftec_Signs_4UP.php on lines 45..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

          class Soup_Signs_4UP_PDF extends FpdfWithBarcode
{
    private $tagdate;
    public function setTagDate($str){
        $this->tagdate = $str;
          Severity: Major
          Found in fannie/admin/labels/pdf_layouts/Soup_Signs_4UP.php and 12 other locations - About 1 hr to fix
          fannie/admin/labels/pdf_layouts/Deli_Big_Special_Signs_1UP.php on lines 13..26
          fannie/admin/labels/pdf_layouts/Soup_Signs_2UP.php on lines 10..23
          fannie/admin/labels/pdf_layouts/WFC_Aisle_Tags.php on lines 8..22
          fannie/admin/labels/pdf_layouts/WFC_Bulk_Repack_14UP.php on lines 10..23
          fannie/admin/labels/pdf_layouts/WFC_Dark_Extended_24UP.php on lines 10..23
          fannie/admin/labels/pdf_layouts/WFC_Dark_Shelf_Labels.php on lines 34..46
          fannie/admin/labels/pdf_layouts/WFC_HerbNspice_3UP.php on lines 13..26
          fannie/admin/labels/pdf_layouts/WFC_HerbNspice_Flat.php on lines 12..25
          fannie/admin/labels/pdf_layouts/WFC_MEAT_14UP.php on lines 10..23
          fannie/admin/labels/pdf_layouts/WFC_New.php on lines 30..42
          fannie/admin/labels/pdf_layouts/WFC_New_Produce_Mockup.php on lines 13..26
          fannie/admin/labels/pdf_layouts/WFC_Produce_SmartSigns.php on lines 13..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status