Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/auth/privileges.php

Summary

Maintainability
A
1 hr
Test Coverage
F
59%

Function addAuth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function addAuth($name,$auth_class,$sub_start='all',$sub_end='all'){
    // 10Nov12 EL Add FANNIE_AUTH_ENABLED
    global $FANNIE_AUTH_ENABLED;
  $sql = dbconnect();
  if (!isAlphanumeric($name) or !isAlphanumeric($auth_class) or
Severity: Minor
Found in fannie/auth/privileges.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

  return true;
Severity: Major
Found in fannie/auth/privileges.php - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status