Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/batches/CAP/CoopDealsReviewPage.php

Summary

Maintainability
D
2 days
Test Coverage
F
18%

Method results_content has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function results_content()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $start = date('Y-m-d', strtotime(FormLib::get_form_value('start',date('Y-m-d'))));
Severity: Major
Found in fannie/batches/CAP/CoopDealsReviewPage.php - About 4 hrs to fix

    Method form_content has 110 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function form_content()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
    Severity: Major
    Found in fannie/batches/CAP/CoopDealsReviewPage.php - About 4 hrs to fix

      Function results_content has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          public function results_content()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $start = date('Y-m-d', strtotime(FormLib::get_form_value('start',date('Y-m-d'))));
      Severity: Minor
      Found in fannie/batches/CAP/CoopDealsReviewPage.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File CoopDealsReviewPage.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/*******************************************************************************

    Copyright 2009,2013 Whole Foods Co-op
      Severity: Minor
      Found in fannie/batches/CAP/CoopDealsReviewPage.php - About 2 hrs to fix

        There are no issues that match your filters.

        Category
        Status