Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/batches/UNFI/RecalculateVendorSRPs.php

Summary

Maintainability
D
2 days
Test Coverage
F
39%

Method get_id_view has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Major
Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 3 hrs to fix

    File RecalculateVendorSRPs.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010,2013 Whole Foods Co-op
    Severity: Minor
    Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 3 hrs to fix

      Function get_id_view has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Minor
      Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method checkPriceChanges has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function checkPriceChanges()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Major
      Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 2 hrs to fix

        Method helpContent has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function helpContent()
    {
        return '<p>Recalculate suggested retail prices for items from
            a given vendor. This takes place in three steps.
            <ul>
        Severity: Major
        Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 2 hrs to fix

          Method get_view has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $q = $dbc->prepare("SELECT vendorID,vendorName FROM vendors ORDER BY vendorName");
          Severity: Minor
          Found in fannie/batches/UNFI/RecalculateVendorSRPs.php - About 1 hr to fix

            There are no issues that match your filters.

            Category
            Status