Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/batches/UNFI/VendorPricingBatchPage.php

Summary

Maintainability
F
1 wk
Test Coverage
F
53%

Method get_id_view has 298 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        $this->addScript($this->config->get('URL') . 'src/javascript/jquery.floatThead.min.js');
        $this->addScript('pricing-batch.js');
        $dbc = $this->connection;
Severity: Major
Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 1 day to fix

    File VendorPricingBatchPage.php has 574 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010 Whole Foods Co-op
    Severity: Major
    Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 1 day to fix

      Function get_id_view has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_view()
    {
        $this->addScript($this->config->get('URL') . 'src/javascript/jquery.floatThead.min.js');
        $this->addScript('pricing-batch.js');
        $dbc = $this->connection;
      Severity: Minor
      Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method javascript_content has 101 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function javascript_content()
    {
        ob_start();
        ?>
        $('.green-green').each(function(){
      Severity: Major
      Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 4 hrs to fix

        Method get_view has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_view()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->OP_DB);
        Severity: Major
        Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 3 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                      if (isset($batchUPCs[$row['upc']]) && !$row['likecoded']) {
                $background = 'selection';
            } elseif (in_array($row['priceRuleTypeID'], $acceptPrtID) || $row['variable_pricing'] == 0 && $row['normal_price'] < 10.00) {
                $background = (
                    ($row['normal_price']+0.10 < $row['rawSRP'])
          Severity: Critical
          Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 2 hrs to fix

            Method css_content has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function css_content()
    {
        return '
        span.grey {
            color: grey;
            Severity: Minor
            Found in fannie/batches/UNFI/VendorPricingBatchPage.php - About 1 hr to fix

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                          if (isset($batchUPCs[$row['upc']]) && !$row['likecoded']) {
                $background = 'selection';
            } elseif (in_array($row['priceRuleTypeID'], $acceptPrtID) || $row['variable_pricing'] == 0 && $row['normal_price'] < 10.00) {
                $background = (
                    ($row['normal_price']+0.10 < $row['rawSRP'])
              Severity: Major
              Found in fannie/batches/UNFI/VendorPricingBatchPage.php and 3 other locations - About 2 days to fix
              fannie/batches/UNFI/VPBPIII.php on lines 803..828
              fannie/batches/UNFI/VPBPIV.php on lines 901..926
              fannie/batches/UNFI/VPBPV.php on lines 958..983

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 436.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      if ($vidsStart != false && $vidsEnd != false) {
            $ret .= "<h3 align=\"center\">Multiple Vendor View</h3>";
            $vidsA = array($vidsStart, $vidsEnd);
            $vidsP = $dbc->prepare("SELECT * FROM batchReviewLog WHERE forced >= ? AND forced < ? 
                AND vid <> 1 GROUP BY vid;");
              Severity: Major
              Found in fannie/batches/UNFI/VendorPricingBatchPage.php and 3 other locations - About 4 hrs to fix
              fannie/batches/UNFI/VPBPIII.php on lines 730..744
              fannie/batches/UNFI/VPBPIV.php on lines 824..838
              fannie/batches/UNFI/VPBPV.php on lines 878..892

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 166.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status