Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/batches/batchhistory/BatchHistoryPage.php

Summary

Maintainability
D
2 days
Test Coverage
F
25%

Function getBatchHistory has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBatchHistory($bid)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Minor
Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getBatchHistory has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getBatchHistory($bid)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Major
Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 3 hrs to fix

    Function get_upc_view has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_upc_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upc = FormLib::get('upc');
    Severity: Minor
    Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_upc_view has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_upc_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upc = FormLib::get('upc');
    Severity: Major
    Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 2 hrs to fix

      Function getProdBatchHist has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getProdBatchHist($upc)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Minor
      Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getProdBatchHist has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getProdBatchHist($upc)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Minor
      Found in fannie/batches/batchhistory/BatchHistoryPage.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status