Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/classlib2.0/data/models/op/BatchesModel.php

Summary

Maintainability
F
5 days
Test Coverage
F
48%

Method forceStartBatch has 250 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function forceStartBatch($id, $upc=false)
    {
        $b_def = $this->connection->tableDefinition($this->name);
        $bt_def = $this->connection->tableDefinition('batchType');
        $exit = isset($bt_def['exitInventory']) ? 'exitInventory' : '0 AS exitInventory';
Severity: Major
Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 1 day to fix

    File BatchesModel.php has 575 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Major
    Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 1 day to fix

      Method finishForce has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function finishForce($id, $updateType, $has_limit=true)
    {
        $columnsP = $this->connection->prepare('
            SELECT p.upc,
                p.normal_price,
      Severity: Major
      Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 4 hrs to fix

        Function forceStartBatch has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

            public function forceStartBatch($id, $upc=false)
    {
        $b_def = $this->connection->tableDefinition($this->name);
        $bt_def = $this->connection->tableDefinition('batchType');
        $exit = isset($bt_def['exitInventory']) ? 'exitInventory' : '0 AS exitInventory';
        Severity: Minor
        Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function finishForce has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            private function finishForce($id, $updateType, $has_limit=true)
    {
        $columnsP = $this->connection->prepare('
            SELECT p.upc,
                p.normal_price,
        Severity: Minor
        Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method forceStopBatch has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function forceStopBatch($id)
    {
        // verify limit columns exist
        $b_def = $this->connection->tableDefinition($this->name);
        $p_def = $this->connection->tableDefinition('products');
        Severity: Major
        Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 3 hrs to fix

          Method getUPCs has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getUPCs($batchID=false)
    {
        if ($batchID === false) {
            $batchID = $this->batchID();
        }
          Severity: Minor
          Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 1 hr to fix

            Method scaleSendPrice has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function scaleSendPrice($batchID)
    {
        $prep = $this->connection->prepare("SELECT upc, salePrice FROM batchList WHERE upc LIKE '002%' AND batchID=?");
        $rows = $this->connection->getAllRows($prep, array($batchID));
        if (count($rows) == 0) {
            Severity: Minor
            Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 1 hr to fix

              Function getUPCs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getUPCs($batchID=false)
    {
        if ($batchID === false) {
            $batchID = $this->batchID();
        }
              Severity: Minor
              Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function forceStopBatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function forceStopBatch($id)
    {
        // verify limit columns exist
        $b_def = $this->connection->tableDefinition($this->name);
        $p_def = $this->connection->tableDefinition('products');
              Severity: Minor
              Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function hookAddColumnowner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function hookAddColumnowner()
    {
        // copy existing values from batchowner.owner to
        // new batches.owner column
        if ($this->connection->table_exists('batchowner')) {
              Severity: Minor
              Found in fannie/classlib2.0/data/models/op/BatchesModel.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  protected function hookAddColumnowner()
    {
        // copy existing values from batchowner.owner to
        // new batches.owner column
        if ($this->connection->table_exists('batchowner')) {
              Severity: Major
              Found in fannie/classlib2.0/data/models/op/BatchesModel.php and 2 other locations - About 1 hr to fix
              fannie/classlib2.0/data/models/op/DepartmentsModel.php on lines 55..69
              fannie/classlib2.0/data/models/op/DepartmentsModel.php on lines 71..85

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 110.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status