Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/classlib2.0/webservices/FannieEntity.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function run has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function run($args=array())
    {
        $ret = array();
        $errored = $this->checkBasicErrors($args, $ret);
        if ($errored !== false) {
Severity: Minor
Found in fannie/classlib2.0/webservices/FannieEntity.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run($args=array())
    {
        $ret = array();
        $errored = $this->checkBasicErrors($args, $ret);
        if ($errored !== false) {
Severity: Major
Found in fannie/classlib2.0/webservices/FannieEntity.php - About 2 hrs to fix

    Method checkBasicErrors has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function checkBasicErrors($args, $ret)
    {
        if (!property_exists($args, 'entity') || !property_exists($args, 'submethod') || !property_exists($args, 'columns')) {
            // missing required arguments
            $ret['error'] = array(
    Severity: Minor
    Found in fannie/classlib2.0/webservices/FannieEntity.php - About 1 hr to fix

      Function checkBasicErrors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkBasicErrors($args, $ret)
    {
        if (!property_exists($args, 'entity') || !property_exists($args, 'submethod') || !property_exists($args, 'columns')) {
            // missing required arguments
            $ret['error'] = array(
      Severity: Minor
      Found in fannie/classlib2.0/webservices/FannieEntity.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in fannie/classlib2.0/webservices/FannieEntity.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $ret;
        Severity: Major
        Found in fannie/classlib2.0/webservices/FannieEntity.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status