Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/cron/management/CronManagementPage.php

Summary

Maintainability
F
5 days
Test Coverage
D
68%

File CronManagementPage.php has 433 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
Severity: Minor
Found in fannie/cron/management/CronManagementPage.php - About 6 hrs to fix

    Method body_content has 108 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function body_content()
    {
        global $FANNIE_ROOT, $FANNIE_URL;
        $ret = '';
    Severity: Major
    Found in fannie/cron/management/CronManagementPage.php - About 4 hrs to fix

      Method simpleRow has 86 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function simpleRow($shortname,$nicename,$cmd,$tab,$i)
    {
        $t_index = 'jobs';
        // if shortname is a task class name, switch indexes
        // and populate defaults if the task is not enabled
      Severity: Major
      Found in fannie/cron/management/CronManagementPage.php - About 3 hrs to fix

        Function body_content has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            function body_content()
    {
        global $FANNIE_ROOT, $FANNIE_URL;
        $ret = '';
        Severity: Minor
        Found in fannie/cron/management/CronManagementPage.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method readCrontab has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function readCrontab()
    {
        global $FANNIE_ROOT;
        $pct = popen('crontab -l 2>&1','r');
        $lines = array();
        Severity: Major
        Found in fannie/cron/management/CronManagementPage.php - About 2 hrs to fix

          Function readCrontab has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              private function readCrontab()
    {
        global $FANNIE_ROOT;
        $pct = popen('crontab -l 2>&1','r');
        $lines = array();
          Severity: Minor
          Found in fannie/cron/management/CronManagementPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function simpleRow has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              private function simpleRow($shortname,$nicename,$cmd,$tab,$i)
    {
        $t_index = 'jobs';
        // if shortname is a task class name, switch indexes
        // and populate defaults if the task is not enabled
          Severity: Minor
          Found in fannie/cron/management/CronManagementPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function scanScripts has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              private function scanScripts($dir,$arr)
    {
        if (!is_dir($dir)){ 
            if (substr($dir,-4) == ".php") {
                $arr[] = $dir;
          Severity: Minor
          Found in fannie/cron/management/CronManagementPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method preprocess has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function preprocess()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        if (FormLib::get_form_value('submit') == 'Save') {
          Severity: Minor
          Found in fannie/cron/management/CronManagementPage.php - About 1 hr to fix

            Function preprocess has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                function preprocess()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        if (FormLib::get_form_value('submit') == 'Save') {
            Severity: Minor
            Found in fannie/cron/management/CronManagementPage.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method advancedRow has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function advancedRow($shortname,$nicename,$cmd,$tab,$i)
    {
        $t_index = 'jobs';
        // if shortname is a task class name, switch indexes
        // and populate defaults if the task is not enabled
            Severity: Minor
            Found in fannie/cron/management/CronManagementPage.php - About 1 hr to fix

              Method simpleRow has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private function simpleRow($shortname,$nicename,$cmd,$tab,$i)
              Severity: Minor
              Found in fannie/cron/management/CronManagementPage.php - About 35 mins to fix

                Method advancedRow has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private function advancedRow($shortname,$nicename,$cmd,$tab,$i)
                Severity: Minor
                Found in fannie/cron/management/CronManagementPage.php - About 35 mins to fix

                  Method getOpts has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private function getOpts($vals, $tab, $shortname, $period, $default)
                  Severity: Minor
                  Found in fannie/cron/management/CronManagementPage.php - About 35 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $ret;
                    Severity: Major
                    Found in fannie/cron/management/CronManagementPage.php - About 30 mins to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (substr($shortname, -4) != '.php') {
            $t_index = 'tasks';
            $obj = new $shortname(); 
            if (!isset($tab['tasks'][$shortname])) {
                // cast-to-string necessary to correctly compare
                      Severity: Major
                      Found in fannie/cron/management/CronManagementPage.php and 1 other location - About 4 hrs to fix
                      fannie/cron/management/CronManagementPage.php on lines 373..388

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 166.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (substr($shortname, -4) != '.php') {
            $t_index = 'tasks';
            $obj = new $shortname(); 
            if (!isset($tab['tasks'][$shortname])) {
                $tab['tasks'][$shortname] = array(
                      Severity: Major
                      Found in fannie/cron/management/CronManagementPage.php and 1 other location - About 4 hrs to fix
                      fannie/cron/management/CronManagementPage.php on lines 260..277

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 166.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status