CORE-POS/IS4C

View on GitHub
fannie/cron/tasks/OrderGenTask.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Function run has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $this->freshenCache($dbc);
        $this->forecast = $this->forecastFactor($dbc, $this->forecast/$this->multiplier, $this->vendors, $this->store);
Severity: Minor
Found in fannie/cron/tasks/OrderGenTask.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $this->freshenCache($dbc);
        $this->forecast = $this->forecastFactor($dbc, $this->forecast/$this->multiplier, $this->vendors, $this->store);
Severity: Major
Found in fannie/cron/tasks/OrderGenTask.php - About 5 hrs to fix

    File OrderGenTask.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*******************************************************************************
    
        Copyright 2015 Whole Foods Co-op
    
    
    Severity: Minor
    Found in fannie/cron/tasks/OrderGenTask.php - About 2 hrs to fix

      Method autoZero has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function autoZero($dbc, $upc, $storeID)
          {
              $parP = $dbc->prepare("SELECT par FROM InventoryCounts WHERE mostRecent=1 AND upc=? AND storeID=? ORDER BY countDate DESC");
              $par = $dbc->getValue($parP, array($upc, $storeID));
      
      
      Severity: Minor
      Found in fannie/cron/tasks/OrderGenTask.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status