CORE-POS/IS4C

View on GitHub
fannie/cron/tasks/PartialBatchTask.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $today = date('Y-m-d');
        $now = new DateTime();
Severity: Minor
Found in fannie/cron/tasks/PartialBatchTask.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $today = date('Y-m-d');
        $now = new DateTime();
Severity: Major
Found in fannie/cron/tasks/PartialBatchTask.php - About 2 hrs to fix

    Method appliesToday has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function appliesToday($repetition)
        {
            $day = date('N');
            switch (strtolower($repetition)) {
                case 'daily':
    Severity: Minor
    Found in fannie/cron/tasks/PartialBatchTask.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return $day == 3;
      Severity: Major
      Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $day == 2;
        Severity: Major
        Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $day == 6;
          Severity: Major
          Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $day == 7;
            Severity: Major
            Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $day == 4;
              Severity: Major
              Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $day == 1;
                Severity: Major
                Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $day == 5;
                  Severity: Major
                  Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return false;
                    Severity: Major
                    Found in fannie/cron/tasks/PartialBatchTask.php - About 30 mins to fix

                      There are no issues that match your filters.

                      Category
                      Status