Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/cron/tasks/ProdUpdateMaintenanceTask.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Function scanCostChanges has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function scanCostChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("
Severity: Minor
Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scanCostChanges has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function scanCostChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("
Severity: Minor
Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

    Function run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function run()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
    Severity: Minor
    Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method scanDeptChanges has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function scanDeptChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("SELECT modified,dept_ID FROM
    Severity: Minor
    Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

      Method scanPriceChanges has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function scanPriceChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("SELECT modified,price FROM
      Severity: Minor
      Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

        Function scanDeptChanges has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private function scanDeptChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("SELECT modified,dept_ID FROM
        Severity: Minor
        Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function scanPriceChanges has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private function scanPriceChanges($dbc, $offset=0)
    {
        $prodUpdateR = $this->changesSince($dbc, $offset);
       
        $chkP = $dbc->prepare("SELECT modified,price FROM
        Severity: Minor
        Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Minor
        Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 1 hr to fix

          Function migrateArchive has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function migrateArchive($dbc)
    {
        $matching = $dbc->matchingColumns('prodUpdate', 'prodUpdateArchive');
        $col_list = '';
        foreach($matching as $column) {
          Severity: Minor
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($prevPrice != $update->cost()) {
                $history->reset();
                $history->upc($upc);
                $history->storeID($update->storeID());
                $history->modified($update->modified());
          Severity: Major
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php and 1 other location - About 1 hr to fix
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 167..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($prevPrice != $update->price()) {
                $history->reset();
                $history->upc($upc);
                $history->storeID($update->storeID());
                $history->modified($update->modified());
          Severity: Major
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php and 1 other location - About 1 hr to fix
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 231..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      if ($upc === null || $upc != $update->upc()) {
                $upc = $update->upc();
                $prevPrice = null;
                $chkR = $dbc->execute($chkP, array($upc));
                if ($dbc->num_rows($chkR) > 0) {
          Severity: Major
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php and 2 other locations - About 1 hr to fix
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 221..229
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 278..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      if ($upc === null || $upc != $update->upc()) {
                $upc = $update->upc();
                $prevPrice = null;
                $chkR = $dbc->execute($chkP, array($upc));
                if ($dbc->numRows($chkR) > 0) {
          Severity: Major
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php and 2 other locations - About 1 hr to fix
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 157..165
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 278..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      if ($upc === null || $upc != $update->upc()) {
                $upc = $update->upc();
                $prevDept = null;
                $chkR = $dbc->execute($chkP, array($upc));
                if ($dbc->num_rows($chkR) > 0) {
          Severity: Major
          Found in fannie/cron/tasks/ProdUpdateMaintenanceTask.php and 2 other locations - About 1 hr to fix
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 157..165
          fannie/cron/tasks/ProdUpdateMaintenanceTask.php on lines 221..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status