Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/cron/tasks/SpecialOrdersTask.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Method run has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        // clean cache
        $this->cleanFileCache();
Severity: Major
Found in fannie/cron/tasks/SpecialOrdersTask.php - About 3 hrs to fix

    File SpecialOrdersTask.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2011 Whole Foods Co-op
    Severity: Minor
    Found in fannie/cron/tasks/SpecialOrdersTask.php - About 3 hrs to fix

      Function run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run()
    {
        // clean cache
        $this->cleanFileCache();
      Severity: Minor
      Found in fannie/cron/tasks/SpecialOrdersTask.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method homelessOrderNotices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function homelessOrderNotices($sql)
    {
        $OP = $this->config->get('OP_DB') . $sql->sep();

        $query = "
      Severity: Minor
      Found in fannie/cron/tasks/SpecialOrdersTask.php - About 1 hr to fix

        Method cleanEmptyOrders has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function cleanEmptyOrders($sql)
    {
        $cleanupQ = sprintf("
            SELECT p.order_id 
            FROM PendingSpecialOrder AS p
        Severity: Minor
        Found in fannie/cron/tasks/SpecialOrdersTask.php - About 1 hr to fix

          Method deliOrderNotices has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function deliOrderNotices($sql)
    {
        $yesterday = date('Y-m-d', strtotime('yesterday'));
        $superID = 4;
          Severity: Minor
          Found in fannie/cron/tasks/SpecialOrdersTask.php - About 1 hr to fix

            Function cleanFileCache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function cleanFileCache()
    {
        $cachepath = sys_get_temp_dir()."/ordercache/";
        if (!is_dir($cachepath) && !mkdir($cachepath)) {
            return false;
            Severity: Minor
            Found in fannie/cron/tasks/SpecialOrdersTask.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method closeOrders has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function closeOrders($sql, $cwIDs, $reason)
    {
        // transfer to completed orders
        $copyQ = "INSERT INTO CompleteSpecialOrder
            SELECT p.* FROM PendingSpecialOrder AS p
            Severity: Minor
            Found in fannie/cron/tasks/SpecialOrdersTask.php - About 1 hr to fix

              Function homelessOrderNotices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function homelessOrderNotices($sql)
    {
        $OP = $this->config->get('OP_DB') . $sql->sep();

        $query = "
              Severity: Minor
              Found in fannie/cron/tasks/SpecialOrdersTask.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      while($row = $sql->fetch_row($result)) {
            $order_ids[] = (int)$row['mixMatch'];
            $trans_ids[] = (int)$row['matched'];

            // log to history if entry doesn't already exist
              Severity: Major
              Found in fannie/cron/tasks/SpecialOrdersTask.php and 1 other location - About 3 hrs to fix
              fannie/cron/nightly.specialorder.php on lines 188..202

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 146.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function getOldCalledWaiting($sql)
    {
        $subquery = "select p.order_id from PendingSpecialOrder as p
            left join SpecialOrders as s
            on p.order_id=s.specialOrderID
              Severity: Major
              Found in fannie/cron/tasks/SpecialOrdersTask.php and 1 other location - About 1 hr to fix
              fannie/cron/tasks/SpecialOrdersTask.php on lines 79..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function get90DaysOld($sql)
    {
        $subquery = "select p.order_id from PendingSpecialOrder as p
            left join SpecialOrders as s
            on p.order_id=s.specialOrderID
              Severity: Major
              Found in fannie/cron/tasks/SpecialOrdersTask.php and 1 other location - About 1 hr to fix
              fannie/cron/tasks/SpecialOrdersTask.php on lines 62..77

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status