Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/cron/tasks/TrackCardsTask.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method trackUser has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function trackUser($dbc, $name, $pan, $hash, $startDate, $whMonths)
    {
        $max = $this->getCardNo($dbc);
        echo "$hash will be " . number_format($max) . "\n";
        $fn = '';
Severity: Major
Found in fannie/cron/tasks/TrackCardsTask.php - About 2 hrs to fix

    Method checkDay has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function checkDay($date)
    {
        $dlog = DTransactionsModel::selectDlog($date);
        $dbc = FannieDB::get($this->config->get('OP_DB'));
    Severity: Minor
    Found in fannie/cron/tasks/TrackCardsTask.php - About 1 hr to fix

      Function checkDay has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkDay($date)
    {
        $dlog = DTransactionsModel::selectDlog($date);
        $dbc = FannieDB::get($this->config->get('OP_DB'));
      Severity: Minor
      Found in fannie/cron/tasks/TrackCardsTask.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method allocateAccounts has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function allocateAccounts()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $res = $dbc->query("SELECT * FROM TrackedCards WHERE "
            . $dbc->monthdiff($dbc->now(), 'firstSeen') . " <= times
      Severity: Minor
      Found in fannie/cron/tasks/TrackCardsTask.php - About 1 hr to fix

        Function trackUser has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function trackUser($dbc, $name, $pan, $hash, $startDate, $whMonths)
    {
        $max = $this->getCardNo($dbc);
        echo "$hash will be " . number_format($max) . "\n";
        $fn = '';
        Severity: Minor
        Found in fannie/cron/tasks/TrackCardsTask.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method trackUser has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function trackUser($dbc, $name, $pan, $hash, $startDate, $whMonths)
        Severity: Minor
        Found in fannie/cron/tasks/TrackCardsTask.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status