CORE-POS/IS4C

View on GitHub
fannie/install/util.php

Summary

Maintainability
F
3 days
Test Coverage
F
55%

File util.php has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2010 Whole Foods Co-op

Severity: Minor
Found in fannie/install/util.php - About 4 hrs to fix

    Function installSelectField has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    function installSelectField($name, &$current_value, $options, $default_value='', $quoted=true)
    {
        if (FormLib::get($name, false) !== false) {
            $current_value = FormLib::get($name);
        } else if ($current_value === null) {
    Severity: Minor
    Found in fannie/install/util.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function confset has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    function confset($key, $value)
    {
        $FILEPATH = realpath(dirname(__FILE__).'/../');
        $lines = array();
        $found = false;
    Severity: Minor
    Found in fannie/install/util.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function installTextField has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    function installTextField($name, &$current_value, $default_value='', $quoted=true, $attributes=array())
    {
        if (FormLib::get($name, false) !== false) {
            $current_value = FormLib::get($name);
        } else if ($current_value === null) {
    Severity: Minor
    Found in fannie/install/util.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method installSelectField has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function installSelectField($name, &$current_value, $options, $default_value='', $quoted=true)
    {
        if (FormLib::get($name, false) !== false) {
            $current_value = FormLib::get($name);
        } else if ($current_value === null) {
    Severity: Minor
    Found in fannie/install/util.php - About 1 hr to fix

      Method confset has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function confset($key, $value)
      {
          $FILEPATH = realpath(dirname(__FILE__).'/../');
          $lines = array();
          $found = false;
      Severity: Minor
      Found in fannie/install/util.php - About 1 hr to fix

        Method check_db_host has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function check_db_host($host,$dbms,$timeout=1)
        {
            if (!function_exists("socket_create")) {
                return true; // test not possible
            }
        Severity: Minor
        Found in fannie/install/util.php - About 1 hr to fix

          Method installTextField has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function installTextField($name, &$current_value, $default_value='', $quoted=true, $attributes=array())
          {
              if (FormLib::get($name, false) !== false) {
                  $current_value = FormLib::get($name);
              } else if ($current_value === null) {
          Severity: Minor
          Found in fannie/install/util.php - About 1 hr to fix

            Function check_writeable has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            function check_writeable($filename, $optional=False, $template=False){
                $basename = basename($filename);
                $failure = ($optional) ? 'blue' : 'red';
                $status = ($optional) ? 'Optional' : 'Warning';
            
            
            Severity: Minor
            Found in fannie/install/util.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method check_writeable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function check_writeable($filename, $optional=False, $template=False){
                $basename = basename($filename);
                $failure = ($optional) ? 'blue' : 'red';
                $status = ($optional) ? 'Optional' : 'Warning';
            
            
            Severity: Minor
            Found in fannie/install/util.php - About 1 hr to fix

              Function check_db_host has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function check_db_host($host,$dbms,$timeout=1)
              {
                  if (!function_exists("socket_create")) {
                      return true; // test not possible
                  }
              Severity: Minor
              Found in fannie/install/util.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method db_test_connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function db_test_connect($host,$type,$db,$user,$pw){
              Severity: Minor
              Found in fannie/install/util.php - About 35 mins to fix

                Method installSelectField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function installSelectField($name, &$current_value, $options, $default_value='', $quoted=true)
                Severity: Minor
                Found in fannie/install/util.php - About 35 mins to fix

                  Method installTextField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function installTextField($name, &$current_value, $default_value='', $quoted=true, $attributes=array())
                  Severity: Minor
                  Found in fannie/install/util.php - About 35 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function sanitizeFieldQuoting($current_value)
                    {
                        // quoted must not contain single quotes
                        $current_value = str_replace("'", '', $current_value);
                        // must not start with backslash
                    Severity: Major
                    Found in fannie/install/util.php and 1 other location - About 3 hrs to fix
                    pos/is4c-nf/install/conf/FormFactory.php on lines 284..298

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 143.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status