Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/ContributionTool.php

Summary

Maintainability
D
2 days
Test Coverage
F
4%

File ContributionTool.php has 412 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

require(dirname(__FILE__) . '/../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../classlib2.0/FannieAPI.php');
Severity: Minor
Found in fannie/item/ContributionTool.php - About 5 hrs to fix

    Method exportAll has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function exportAll($store)
    {
        $promoP = $this->connection->prepare('
            SELECT q.upc, SUM(total), SUM(saleTotal)
            FROM ' . FannieDB::fqn('productWeeklyLastQuarter', 'arch') . ' as q
    Severity: Major
    Found in fannie/item/ContributionTool.php - About 2 hrs to fix

      Method preprocess has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function preprocess()
    {
        $stores = FormLib::storePicker('store', false);
        $items = FormLib::get('items', 50);
        $vendors = FormLib::get('vendors', 10);
      Severity: Major
      Found in fannie/item/ContributionTool.php - About 2 hrs to fix

        Method getBasics has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getBasics($store, $super)
    {
        $query = "SELECT m.super_name AS name, MAX(m.superID) AS superID,
            SUM(percentageStoreSales) AS percentage,
            SUM(CASE WHEN p.cost <> 0 AND normal_price <> 0 THEN 1 ELSE 0 END) as hasCost,
        Severity: Major
        Found in fannie/item/ContributionTool.php - About 2 hrs to fix

          Method get_view has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function get_view()
    {
        $stores = FormLib::storePicker('store', false);
        $items = FormLib::get('items', 50);
        $vendors = FormLib::get('vendors', 10);
          Severity: Minor
          Found in fannie/item/ContributionTool.php - About 1 hr to fix

            Method getVendors has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function getVendors($store, $limit, $super, $dept)
    {
        if (!isset($this->vendorP)) {
            $query = "
                SELECT COALESCE(v.vendorName, 'Unknown') AS vendorName,
            Severity: Minor
            Found in fannie/item/ContributionTool.php - About 1 hr to fix

              Method getItems has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function getItems($store, $limit, $super, $dept, $highlight)
    {
        if (!isset($this->itemP)) {
            $query = "
                SELECT p.upc, p.brand, p.description,
              Severity: Minor
              Found in fannie/item/ContributionTool.php - About 1 hr to fix

                Function preprocess has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function preprocess()
    {
        $stores = FormLib::storePicker('store', false);
        $items = FormLib::get('items', 50);
        $vendors = FormLib::get('vendors', 10);
                Severity: Minor
                Found in fannie/item/ContributionTool.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getItems has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private function getItems($store, $limit, $super, $dept, $highlight)
                Severity: Minor
                Found in fannie/item/ContributionTool.php - About 35 mins to fix

                  Function allItemsHTML has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function allItemsHTML($data, $highlight)
    {
        $uri = $_SERVER['REQUEST_URI'];
        $uri .= strpos($uri, '?') ? '&itemExcel=1' : '?itemExcel=1';
        $ret = '<p><a href="' . $uri . '">Export to Excel</a></p>';
                  Severity: Minor
                  Found in fannie/item/ContributionTool.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exportAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function exportAll($store)
    {
        $promoP = $this->connection->prepare('
            SELECT q.upc, SUM(total), SUM(saleTotal)
            FROM ' . FannieDB::fqn('productWeeklyLastQuarter', 'arch') . ' as q
                  Severity: Minor
                  Found in fannie/item/ContributionTool.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (!isset($this->vendorP)) {
            $query = "
                SELECT COALESCE(v.vendorName, 'Unknown') AS vendorName,
                    SUM(q.percentageStoreSales) AS store,
                    SUM(q.percentageSuperDeptSales) AS super,
                  Severity: Minor
                  Found in fannie/item/ContributionTool.php and 1 other location - About 30 mins to fix
                  fannie/item/ContributionTool.php on lines 353..374

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 90.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (!isset($this->itemP)) {
            $query = "
                SELECT p.upc, p.brand, p.description,
                    CASE WHEN p.cost = 0 THEN NULL ELSE (p.normal_price-p.cost)/p.normal_price END AS margin,
                    q.percentageStoreSales AS store,
                  Severity: Minor
                  Found in fannie/item/ContributionTool.php and 1 other location - About 30 mins to fix
                  fannie/item/ContributionTool.php on lines 259..280

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 90.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status