CORE-POS/IS4C

View on GitHub
fannie/item/CoopDealsLookupPage.php

Summary

Maintainability
F
3 days
Test Coverage
F
18%

Method get_month_upc_view has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_month_upc_view($month=false)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        if (FormLib::get('linea') != 1) {
Severity: Major
Found in fannie/item/CoopDealsLookupPage.php - About 1 day to fix

    File CoopDealsLookupPage.php has 441 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*******************************************************************************
    
        Copyright 2013 Whole Foods Community Co-op
    
    
    Severity: Minor
    Found in fannie/item/CoopDealsLookupPage.php - About 6 hrs to fix

      Function get_month_upc_view has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_month_upc_view($month=false)
          {
              global $FANNIE_OP_DB;
              $dbc = FannieDB::get($FANNIE_OP_DB);
              if (FormLib::get('linea') != 1) {
      Severity: Minor
      Found in fannie/item/CoopDealsLookupPage.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_insert_view has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function get_insert_view()
          {
              global $FANNIE_OP_DB;
              $dbc = FannieDB::get($FANNIE_OP_DB);
      
      
      Severity: Minor
      Found in fannie/item/CoopDealsLookupPage.php - About 1 hr to fix

        Method monthOptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function monthOptions()
            {
                global $FANNIE_OP_DB;
                $dbc = FannieDB::get($FANNIE_OP_DB);
                $prep = $dbc->prepare("SELECT dealSet FROM CoopDealsItems GROUP BY dealSet");
        Severity: Minor
        Found in fannie/item/CoopDealsLookupPage.php - About 1 hr to fix

          Function get_insert_view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              function get_insert_view()
              {
                  global $FANNIE_OP_DB;
                  $dbc = FannieDB::get($FANNIE_OP_DB);
          
          
          Severity: Minor
          Found in fannie/item/CoopDealsLookupPage.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function monthOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function monthOptions()
              {
                  global $FANNIE_OP_DB;
                  $dbc = FannieDB::get($FANNIE_OP_DB);
                  $prep = $dbc->prepare("SELECT dealSet FROM CoopDealsItems GROUP BY dealSet");
          Severity: Minor
          Found in fannie/item/CoopDealsLookupPage.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status