Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/EditItemsFromSearch.php

Summary

Maintainability
D
2 days
Test Coverage
F
58%

File EditItemsFromSearch.php has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Community Co-op
Severity: Minor
Found in fannie/item/EditItemsFromSearch.php - About 5 hrs to fix

    Method post_u_view has 114 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function post_u_view()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        $ret = '';
    Severity: Major
    Found in fannie/item/EditItemsFromSearch.php - About 4 hrs to fix

      Function post_save_handler has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          function post_save_handler()
    {
        global $FANNIE_OP_DB;

        $upcs = FormLib::get('upc', array());
      Severity: Minor
      Found in fannie/item/EditItemsFromSearch.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method post_save_handler has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function post_save_handler()
    {
        global $FANNIE_OP_DB;

        $upcs = FormLib::get('upc', array());
      Severity: Major
      Found in fannie/item/EditItemsFromSearch.php - About 2 hrs to fix

        Function setDiscounts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function setDiscounts($pmodel, $arr, $index)
    {
        if (!isset($arr[$index])) {
            return $pmodel;
        }
        Severity: Minor
        Found in fannie/item/EditItemsFromSearch.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function post_u_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            function post_u_handler()
    {
        if (!is_array($this->u)) {
            $this->u = array($this->u);
        }
        Severity: Minor
        Found in fannie/item/EditItemsFromSearch.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private function arrayToOpts($arr, $selected=-999, $id_label=false)
    {
        $opts = '';
        foreach ($arr as $num => $name) {
            if ($id_label === true) {
        Severity: Major
        Found in fannie/item/EditItemsFromSearch.php and 1 other location - About 1 hr to fix
        fannie/item/ProdLocationEditor.php on lines 692..705

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            function post_u_handler()
    {
        if (!is_array($this->u)) {
            $this->u = array($this->u);
        }
        Severity: Major
        Found in fannie/item/EditItemsFromSearch.php and 2 other locations - About 1 hr to fix
        fannie/batches/BatchFromSearch.php on lines 228..245
        fannie/item/hobartcsv/SyncFromSearch.php on lines 228..245

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status