Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/FloorSections/NewPageO.php

Summary

Maintainability
D
2 days
Test Coverage

Method get_view has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_view()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        // for now, only denfeld is being shown
Severity: Major
Found in fannie/item/FloorSections/NewPageO.php - About 3 hrs to fix

    Function get_view has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_view()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        // for now, only denfeld is being shown
    Severity: Minor
    Found in fannie/item/FloorSections/NewPageO.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File NewPageO.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2014 Whole Foods Community Co-op
    Severity: Minor
    Found in fannie/item/FloorSections/NewPageO.php - About 2 hrs to fix

      Method javascriptContent has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function javascriptContent()
    {
        return <<<JAVASCRIPT
$('#fannie-main-content').css('border', '0px solid transparent');
$('.dept').on('click', function(){
      Severity: Minor
      Found in fannie/item/FloorSections/NewPageO.php - About 2 hrs to fix

        Method css_content has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function css_content()
    {
        return <<<HTML
#mymap {
    width: 500vw;
        Severity: Minor
        Found in fannie/item/FloorSections/NewPageO.php - About 1 hr to fix

          Method post_section_handler has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function post_section_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $section = FormLib::get('section');
          Severity: Minor
          Found in fannie/item/FloorSections/NewPageO.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function post_section_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $section = FormLib::get('section');
            Severity: Major
            Found in fannie/item/FloorSections/NewPageO.php and 1 other location - About 5 hrs to fix
            fannie/item/FloorSections/SubLocationViewer.php on lines 132..166

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 188.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    while ($row = $dbc->fetchRow($res)) {
            $dept = $row['department'] . '-' . $row['dept_name'];
            $fsName = $row['name'];
            if (!isset($subdata[$fsName]) && !isset($subdata[$fsName][$row['subSection']]) ) {
                $subdata[$fsName][$row['subSection']][$dept] = 1;
            Severity: Major
            Found in fannie/item/FloorSections/NewPageO.php and 1 other location - About 3 hrs to fix
            fannie/item/FloorSections/SubLocationViewer.php on lines 65..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $order = array(
            'Cool 1' => 1,
             'Wellness 1' => 2, 
             '5' => 0, 
             'Wellness 2' => 2,
            Severity: Minor
            Found in fannie/item/FloorSections/NewPageO.php and 1 other location - About 40 mins to fix
            fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php on lines 84..102

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status