Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/PriceRuleEditor.php

Summary

Maintainability
D
2 days
Test Coverage

File PriceRuleEditor.php has 385 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2015 Whole Foods Co-op
Severity: Minor
Found in fannie/item/PriceRuleEditor.php - About 5 hrs to fix

    Method javascriptContent has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function javascriptContent()
    {
        return <<<JAVASCRIPT
var saved = false;
    Severity: Major
    Found in fannie/item/PriceRuleEditor.php - About 3 hrs to fix

      Method get_brandList_view has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_brandList_view()
    {

        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Major
      Found in fannie/item/PriceRuleEditor.php - About 2 hrs to fix

        Method get_view has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $vendOpts = "<option value=0></option>";
        Severity: Major
        Found in fannie/item/PriceRuleEditor.php - About 2 hrs to fix

          Method getTableData has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getTableData($dbc, $searchType, $searchValue)
    {
        $items = array();
        $where = ($searchType == 'VENDOR') ? ' default_vendor_id = ? ' : ' p.brand = ? ';
        if ($searchType == 'UPCS') {
          Severity: Minor
          Found in fannie/item/PriceRuleEditor.php - About 1 hr to fix

            Method get_upc_handler has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function get_upc_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upcs = FormLib::get('upcs');
            Severity: Minor
            Found in fannie/item/PriceRuleEditor.php - About 1 hr to fix

              Function get_brandList_view has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function get_brandList_view()
    {

        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
              Severity: Minor
              Found in fannie/item/PriceRuleEditor.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getTableData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getTableData($dbc, $searchType, $searchValue)
    {
        $items = array();
        $where = ($searchType == 'VENDOR') ? ' default_vendor_id = ? ' : ' p.brand = ? ';
        if ($searchType == 'UPCS') {
              Severity: Minor
              Found in fannie/item/PriceRuleEditor.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_upc_handler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function get_upc_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upcs = FormLib::get('upcs');
              Severity: Minor
              Found in fannie/item/PriceRuleEditor.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status