Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/ProdReviewPage.php

Summary

Maintainability
F
1 wk
Test Coverage
F
33%

File ProdReviewPage.php has 1304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2017 Whole Foods Community Co-op
Severity: Major
Found in fannie/item/ProdReviewPage.php - About 3 days to fix

    Method javascript_content has 229 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

       public function javascript_content()
   {
    return <<<JAVASCRIPT
var lastChecked = null;
var i = 0;
    Severity: Major
    Found in fannie/item/ProdReviewPage.php - About 1 day to fix

      Function get_schedule_view has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_schedule_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Minor
      Found in fannie/item/ProdReviewPage.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_batchLog_view has 139 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_batchLog_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Major
      Found in fannie/item/ProdReviewPage.php - About 5 hrs to fix

        Method get_schedule_view has 125 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_schedule_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Major
        Found in fannie/item/ProdReviewPage.php - About 5 hrs to fix

          Method get_vendor_view has 115 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_vendor_view()
    {
        $vid = $this->vendor;
        $vendorID = FormLib::get('vendor');
          Severity: Major
          Found in fannie/item/ProdReviewPage.php - About 4 hrs to fix

            Method get_view has 99 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
            Severity: Major
            Found in fannie/item/ProdReviewPage.php - About 3 hrs to fix

              Function get_batchLog_view has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function get_batchLog_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
              Severity: Minor
              Found in fannie/item/ProdReviewPage.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method css_content has 86 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function css_content()
    {
        return <<<HTML
span.supertab {
    padding: 2px;
              Severity: Major
              Found in fannie/item/ProdReviewPage.php - About 3 hrs to fix

                Function get_vendor_view has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_vendor_view()
    {
        $vid = $this->vendor;
        $vendorID = FormLib::get('vendor');
                Severity: Minor
                Found in fannie/item/ProdReviewPage.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                ProdReviewPage has 25 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class ProdReviewPage extends FannieRESTfulPage
{
    protected $must_authenticate = True;
    protected $auth_classes = array('admin');
                Severity: Minor
                Found in fannie/item/ProdReviewPage.php - About 2 hrs to fix

                  Method get_schedule_setup_view has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function get_schedule_setup_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
                  Severity: Major
                  Found in fannie/item/ProdReviewPage.php - About 2 hrs to fix

                    Method get_list_view has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function get_list_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
                    Severity: Major
                    Found in fannie/item/ProdReviewPage.php - About 2 hrs to fix

                      Function draw_table has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function draw_table($data,$dbc)
    {
        $table = '<table class="table table-condensed table-striped small">';
        $table .= '<thead><th>UPC</th><th>Brand</th><th>Description</th>
            <th>Last Reviewed</th></thead><tbody>';
                      Severity: Minor
                      Found in fannie/item/ProdReviewPage.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method get_batchLog_add_handler has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function get_batchLog_add_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $bid = FormLib::get('bid');
                      Severity: Minor
                      Found in fannie/item/ProdReviewPage.php - About 1 hr to fix

                        Method helpContent has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function helpContent()
    {
        return <<<HTML
        <h4>Product Review</h4>
        <p>Mark a product as reviewed once the following
                        Severity: Minor
                        Found in fannie/item/ProdReviewPage.php - About 1 hr to fix

                          Method get_list_save_handler has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function get_list_save_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upcs = FormLib::get('upcs');
                          Severity: Minor
                          Found in fannie/item/ProdReviewPage.php - About 1 hr to fix

                            Method draw_table has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function draw_table($data,$dbc)
    {
        $table = '<table class="table table-condensed table-striped small">';
        $table .= '<thead><th>UPC</th><th>Brand</th><th>Description</th>
            <th>Last Reviewed</th></thead><tbody>';
                            Severity: Minor
                            Found in fannie/item/ProdReviewPage.php - About 1 hr to fix

                              Function get_list_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function get_list_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function getBatchItemDiscrep has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function getBatchItemDiscrep($dbc)
    {
        $found = array();
        $tmp = array();
        $prep = $dbc->prepare("SELECT * from batchReviewLog AS l
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function get_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function get_batchLog_add_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function get_batchLog_add_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $bid = FormLib::get('bid');
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function get_list_save_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function get_list_save_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $upcs = FormLib::get('upcs');
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function get_batchLog_deleteRow_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $bid = FormLib::get('id');
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php and 1 other location - About 40 mins to fix
                              fannie/item/ProdReviewPage.php on lines 405..416

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 93.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function get_batchLog_print_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $bid = FormLib::get('bid');
                              Severity: Minor
                              Found in fannie/item/ProdReviewPage.php and 1 other location - About 40 mins to fix
                              fannie/item/ProdReviewPage.php on lines 313..323

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 93.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status