Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/addShelfTag.php

Summary

Maintainability
C
1 day
Test Coverage
F
30%

Method get_upc_view has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_upc_view()
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $newUpc = FormLib::get('newUpc', false);
Severity: Major
Found in fannie/item/addShelfTag.php - About 3 hrs to fix

    Method post_upc_view has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function post_upc_view()
    {
        if(FormLib::get('print') == "now") {
          return $this->print_tag();
        } else {
    Severity: Major
    Found in fannie/item/addShelfTag.php - About 2 hrs to fix

      File addShelfTag.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/*******************************************************************************

    Copyright 2009 Whole Foods Co-op
      Severity: Minor
      Found in fannie/item/addShelfTag.php - About 2 hrs to fix

        Method print_tag has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function print_tag() {
      $offset = FormLib::get('offset', 0);

      $data = array(array(
        'normal_price' => FormLib::get('price'),
        Severity: Minor
        Found in fannie/item/addShelfTag.php - About 1 hr to fix

          Function print_tag has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function print_tag() {
      $offset = FormLib::get('offset', 0);

      $data = array(array(
        'normal_price' => FormLib::get('price'),
          Severity: Minor
          Found in fannie/item/addShelfTag.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function post_upc_view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function post_upc_view()
    {
        if(FormLib::get('print') == "now") {
          return $this->print_tag();
        } else {
          Severity: Minor
          Found in fannie/item/addShelfTag.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status