Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/departments/DepartmentEditor.php

Summary

Maintainability
C
1 day
Test Coverage
F
51%

Method get_view has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $depts = "<option value=0>Select a department...</option>";
Severity: Minor
Found in fannie/item/departments/DepartmentEditor.php - About 1 hr to fix

    Method post_handler has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function post_handler()
    {
        $dbc = $this->connection;

        $deptID = FormLib::get('did',0);
    Severity: Minor
    Found in fannie/item/departments/DepartmentEditor.php - About 1 hr to fix

      Method get_id_handler has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
      Severity: Minor
      Found in fannie/item/departments/DepartmentEditor.php - About 1 hr to fix

        Function post_handler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function post_handler()
    {
        $dbc = $this->connection;

        $deptID = FormLib::get('did',0);
        Severity: Minor
        Found in fannie/item/departments/DepartmentEditor.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function legacySave has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function legacySave($dbc, $deptID, $margin, $pcode)
    {
        $sets = array(
            array('deptMargin', 'margin', $margin),
            array('deptSalesCodes', 'salesCode', $pcode),
        Severity: Minor
        Found in fannie/item/departments/DepartmentEditor.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDept has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getDept($dbc, $deptID)
    {
        $dept = new DepartmentsModel($dbc);
        if ($deptID !== -1) { // not new department
            $dept->dept_no($deptID);
        Severity: Minor
        Found in fannie/item/departments/DepartmentEditor.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_id_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function get_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Minor
        Found in fannie/item/departments/DepartmentEditor.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $depts = "<option value=0>Select a department...</option>";
        Severity: Minor
        Found in fannie/item/departments/DepartmentEditor.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status