Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/departments/SuperDeptEditor.php

Summary

Maintainability
C
1 day
Test Coverage
D
65%

Method body_content has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function body_content()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $def = $dbc->tableDefinition('superDeptNames');
Severity: Major
Found in fannie/item/departments/SuperDeptEditor.php - About 4 hrs to fix

    File SuperDeptEditor.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2009,2013 Whole Foods Co-op
    Severity: Minor
    Found in fannie/item/departments/SuperDeptEditor.php - About 2 hrs to fix

      Method ajax_response has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function ajax_response($action)
    {
        global $FANNIE_OP_DB;
        switch ($action) {
        case 'deptsInSuper':
      Severity: Minor
      Found in fannie/item/departments/SuperDeptEditor.php - About 1 hr to fix

        Function ajax_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function ajax_response($action)
    {
        global $FANNIE_OP_DB;
        switch ($action) {
        case 'deptsInSuper':
        Severity: Minor
        Found in fannie/item/departments/SuperDeptEditor.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method save_super_dept has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function save_super_dept($id,$name,$depts)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        if ($id == -1) {
        Severity: Minor
        Found in fannie/item/departments/SuperDeptEditor.php - About 1 hr to fix

          Function body_content has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              function body_content()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $def = $dbc->tableDefinition('superDeptNames');
          Severity: Minor
          Found in fannie/item/departments/SuperDeptEditor.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function save_super_dept has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function save_super_dept($id,$name,$depts)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        if ($id == -1) {
          Severity: Minor
          Found in fannie/item/departments/SuperDeptEditor.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status