Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/handheld/ItemStatusPage.php

Summary

Maintainability
D
2 days
Test Coverage
F
48%

Method get_id_view has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        global $FANNIE_OP_DB;
        $ret = $this->get_view();
        $upc = BarcodeLib::padUPC($this->id);
Severity: Major
Found in fannie/item/handheld/ItemStatusPage.php - About 6 hrs to fix

    Function get_id_view has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_id_view()
    {
        global $FANNIE_OP_DB;
        $ret = $this->get_view();
        $upc = BarcodeLib::padUPC($this->id);
    Severity: Minor
    Found in fannie/item/handheld/ItemStatusPage.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ItemStatusPage.php has 311 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2014 Whole Foods Community Co-op
    Severity: Minor
    Found in fannie/item/handheld/ItemStatusPage.php - About 3 hrs to fix

      Method get_narrowTag_upc_handler has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_narrowTag_upc_handler()
    {
        $dbc = $this->connection;
        $storeID = Store::getIdByIp();
        $dbc->selectDB($this->config->get('OP_DB'));
      Severity: Minor
      Found in fannie/item/handheld/ItemStatusPage.php - About 1 hr to fix

        Method get_tagID_upc_handler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_tagID_upc_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $product = new ProductsModel($dbc);
        Severity: Minor
        Found in fannie/item/handheld/ItemStatusPage.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status