CORE-POS/IS4C

View on GitHub
fannie/item/hobartcsv/ScaleEditor.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
23%

Function post_id_handler has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function post_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $scale = new ServiceScalesModel($dbc);
Severity: Minor
Found in fannie/item/hobartcsv/ScaleEditor.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_view has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $scales = new ServiceScalesModel($dbc);
Severity: Major
Found in fannie/item/hobartcsv/ScaleEditor.php - About 2 hrs to fix

    Method post_id_handler has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function post_id_handler()
        {
            global $FANNIE_OP_DB;
            $dbc = FannieDB::get($FANNIE_OP_DB);
            $scale = new ServiceScalesModel($dbc);
    Severity: Major
    Found in fannie/item/hobartcsv/ScaleEditor.php - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status