Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/hobartcsv/SyncFromSearch.php

Summary

Maintainability
D
1 day
Test Coverage
F
30%

File SyncFromSearch.php has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Community Co-op
Severity: Minor
Found in fannie/item/hobartcsv/SyncFromSearch.php - About 3 hrs to fix

    Function post_sendall_handler has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        function post_sendall_handler()
    {
        global $FANNIE_OP_DB;
        $model = new ScaleItemsModel(FannieDB::get($FANNIE_OP_DB));
        $upcs = FormLib::get('upcs', array());
    Severity: Minor
    Found in fannie/item/hobartcsv/SyncFromSearch.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post_u_view has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function post_u_view()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        $this->addScript($FANNIE_URL.'/src/javascript/jquery.js');
        $this->addCssFile($FANNIE_URL.'/src/style.css');
    Severity: Major
    Found in fannie/item/hobartcsv/SyncFromSearch.php - About 2 hrs to fix

      Method post_sendall_handler has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function post_sendall_handler()
    {
        global $FANNIE_OP_DB;
        $model = new ScaleItemsModel(FannieDB::get($FANNIE_OP_DB));
        $upcs = FormLib::get('upcs', array());
      Severity: Major
      Found in fannie/item/hobartcsv/SyncFromSearch.php - About 2 hrs to fix

        Method post_sendupc_handler has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function post_sendupc_handler()
    {
        global $FANNIE_OP_DB;
        $model = new ScaleItemsModel(FannieDB::get($FANNIE_OP_DB));
        $model->plu(BarcodeLib::padUPC($this->sendupc));
        Severity: Minor
        Found in fannie/item/hobartcsv/SyncFromSearch.php - About 1 hr to fix

          Method getItemInfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getItemInfo($model)
    {
        // extract scale PLU
        $s_plu = COREPOS\Fannie\API\item\ServiceScaleLib::upcToPLU($model->plu());
          Severity: Minor
          Found in fannie/item/hobartcsv/SyncFromSearch.php - About 1 hr to fix

            Function post_sendupc_handler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                function post_sendupc_handler()
    {
        global $FANNIE_OP_DB;
        $model = new ScaleItemsModel(FannieDB::get($FANNIE_OP_DB));
        $model->plu(BarcodeLib::padUPC($this->sendupc));
            Severity: Minor
            Found in fannie/item/hobartcsv/SyncFromSearch.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function post_u_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                function post_u_handler()
    {
        if (!is_array($this->u)) {
            $this->u = array($this->u);
        }
            Severity: Minor
            Found in fannie/item/hobartcsv/SyncFromSearch.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                function post_u_handler()
    {
        if (!is_array($this->u)) {
            $this->u = array($this->u);
        }
            Severity: Major
            Found in fannie/item/hobartcsv/SyncFromSearch.php and 2 other locations - About 1 hr to fix
            fannie/batches/BatchFromSearch.php on lines 228..245
            fannie/item/EditItemsFromSearch.php on lines 210..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status