CORE-POS/IS4C

View on GitHub
fannie/item/hobartcsv/writecsv.php

Summary

Maintainability
D
2 days
Test Coverage
F
38%

Function writeitem has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

function writeitem($filename,$scaletype,$scaleip,$department,$writetype,
                   $plu,$itemdesc,$tare,$shelflife,$price,$bycount,$type,
                   $exception,$label,$graphics){
  $fp = fopen($filename,"w+");
  fputs($fp,"Record Type,Task Department,Task Destination,Task Destination Device,Task Destination Type\r\n");
Severity: Minor
Found in fannie/item/hobartcsv/writecsv.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method writeitem has 15 arguments (exceeds 4 allowed). Consider refactoring.
Open

function writeitem($filename,$scaletype,$scaleip,$department,$writetype,
                   $plu,$itemdesc,$tare,$shelflife,$price,$bycount,$type,
                   $exception,$label,$graphics){
Severity: Major
Found in fannie/item/hobartcsv/writecsv.php - About 1 hr to fix

    Method writeitem has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function writeitem($filename,$scaletype,$scaleip,$department,$writetype,
                       $plu,$itemdesc,$tare,$shelflife,$price,$bycount,$type,
                       $exception,$label,$graphics){
      $fp = fopen($filename,"w+");
      fputs($fp,"Record Type,Task Department,Task Destination,Task Destination Device,Task Destination Type\r\n");
    Severity: Minor
    Found in fannie/item/hobartcsv/writecsv.php - About 1 hr to fix

      Function writetext has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function writetext($filename,$scaletype,$scaleip,$department,$plu,$text){
        $fp = fopen($filename,"w+");
        fputs($fp,"Record Type,Task Department,Task Destination,Task Destination Device,Task Destination Type\r\n");
        fputs($fp,"ExecuteOneTask,{$department},{$scaleip},{$scaletype},SCALE\r\n");
        fputs($fp,"Record Type,Expanded Text Number,Expanded Text\r\n");
      Severity: Minor
      Found in fannie/item/hobartcsv/writecsv.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method writetext has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function writetext($filename,$scaletype,$scaleip,$department,$plu,$text){
      Severity: Minor
      Found in fannie/item/hobartcsv/writecsv.php - About 45 mins to fix

        Method delete_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function delete_item($filename,$scaletype,$scaleip,$department,$plu){
        Severity: Minor
        Found in fannie/item/hobartcsv/writecsv.php - About 35 mins to fix

          Method delete_text has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function delete_text($filename,$scaletype,$scaleip,$department,$plu){
          Severity: Minor
          Found in fannie/item/hobartcsv/writecsv.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function delete_text($filename,$scaletype,$scaleip,$department,$plu){
              $fp = fopen($filename,"w+");
              fputs($fp,"Record Type,Task Department,Task Destination,Task Destination Device,Task Destination Type\r\n");
              fputs($fp,"ExecuteOneTask,{$department},{$scaleip},{$scaletype},SCALE\r\n");
              fputs($fp,"Record Type,Expanded Text Number\r\n");
            Severity: Major
            Found in fannie/item/hobartcsv/writecsv.php and 1 other location - About 3 hrs to fix
            fannie/item/hobartcsv/writecsv.php on lines 97..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 153.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function delete_item($filename,$scaletype,$scaleip,$department,$plu){
              $fp = fopen($filename,"w+");
              fputs($fp,"Record Type,Task Department,Task Destination,Task Destination Device,Task Destination Type\r\n");
              fputs($fp,"ExecuteOneTask,{$department},{$scaleip},{$scaletype},SCALE\r\n");
              fputs($fp,"Record Type,PLU Number\r\n");
            Severity: Major
            Found in fannie/item/hobartcsv/writecsv.php and 1 other location - About 3 hrs to fix
            fannie/item/hobartcsv/writecsv.php on lines 114..129

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 153.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status