Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/likecodes/cool/RdwImport.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method post_handler has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_handler()
    {
        $this->data = array();
        $this->invoice = array();
        $invoice = FormLib::get('invoice');
Severity: Major
Found in fannie/item/likecodes/cool/RdwImport.php - About 2 hrs to fix

    Function post_handler has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function post_handler()
    {
        $this->data = array();
        $this->invoice = array();
        $invoice = FormLib::get('invoice');
    Severity: Minor
    Found in fannie/item/likecodes/cool/RdwImport.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post_view has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function post_view()
    {
        $vendorID = 136;
        $likeP = $this->connection->prepare("SELECT likeCode
            FROM VendorLikeCodeMap
    Severity: Minor
    Found in fannie/item/likecodes/cool/RdwImport.php - About 1 hr to fix

      Function post_view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function post_view()
    {
        $vendorID = 136;
        $likeP = $this->connection->prepare("SELECT likeCode
            FROM VendorLikeCodeMap
      Severity: Minor
      Found in fannie/item/likecodes/cool/RdwImport.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSize($item)
    {
        $item = trim(strtoupper($item));
        if (preg_match('/^(\d+) *LB (.*)/', $item, $matches)) {
            return array($matches[2], $matches[1], 'LB');
      Severity: Minor
      Found in fannie/item/likecodes/cool/RdwImport.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return array($matches[2], $case, $unit . ' LB');
      Severity: Major
      Found in fannie/item/likecodes/cool/RdwImport.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return array($matches[3], ($min + $max) / 2, $matches[2]);
        Severity: Major
        Found in fannie/item/likecodes/cool/RdwImport.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return array($item, 1, '');
          Severity: Major
          Found in fannie/item/likecodes/cool/RdwImport.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return array($matches[2], 1, $matches[1]);
            Severity: Major
            Found in fannie/item/likecodes/cool/RdwImport.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function getPO($ref, $store, $date)
    {
        $prep = $this->connection->prepare("SELECT orderID FROM PurchaseOrder
            WHERE vendorInvoiceID=? AND vendorID=136 AND storeID=?");
        $exists = $this->connection->getValue($prep, array($ref, $store));
              Severity: Major
              Found in fannie/item/likecodes/cool/RdwImport.php and 1 other location - About 2 hrs to fix
              fannie/purchasing/importers/RdwCreditImport.php on lines 78..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 140.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status