Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/modules/ScaleItemModule.php

Summary

Maintainability
F
3 days
Test Coverage
F
38%

Method SaveFormData has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function SaveFormData($upc)
    {
        /* check if data was submitted */
        if (FormLib::get('s_plu') === '') return False;
Severity: Major
Found in fannie/item/modules/ScaleItemModule.php - About 7 hrs to fix

    Method showEditForm has 186 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function showEditForm($upc, $display_mode=1, $expand_mode=1)
    {
        $upc = BarcodeLib::padUPC($upc);

        $dbc = $this->db();
    Severity: Major
    Found in fannie/item/modules/ScaleItemModule.php - About 7 hrs to fix

      Function SaveFormData has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
      Open

          function SaveFormData($upc)
    {
        /* check if data was submitted */
        if (FormLib::get('s_plu') === '') return False;
      Severity: Minor
      Found in fannie/item/modules/ScaleItemModule.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File ScaleItemModule.php has 388 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op, Duluth, MN
      Severity: Minor
      Found in fannie/item/modules/ScaleItemModule.php - About 5 hrs to fix

        Function showEditForm has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            public function showEditForm($upc, $display_mode=1, $expand_mode=1)
    {
        $upc = BarcodeLib::padUPC($upc);

        $dbc = $this->db();
        Severity: Minor
        Found in fannie/item/modules/ScaleItemModule.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status