Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/vendors/BrowseVendorItems.php

Summary

Maintainability
D
2 days
Test Coverage
F
38%

File BrowseVendorItems.php has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2009 Whole Foods Co-op
Severity: Minor
Found in fannie/item/vendors/BrowseVendorItems.php - About 4 hrs to fix

    Method showCategoryItems has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showCategoryItems($vid,$did,$brand,$ds=-999)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
    Severity: Major
    Found in fannie/item/vendors/BrowseVendorItems.php - About 3 hrs to fix

      Method body_content has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function body_content()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        $vid = FormLib::get_form_value('vid');
        if ($vid === ''){
      Severity: Major
      Found in fannie/item/vendors/BrowseVendorItems.php - About 2 hrs to fix

        Method addToPos has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function addToPos($upc,$vid,$price,$dept,$tags=-1)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Minor
        Found in fannie/item/vendors/BrowseVendorItems.php - About 1 hr to fix

          Method guessSuper has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function guessSuper($vid, $did, $brand)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
          Severity: Minor
          Found in fannie/item/vendors/BrowseVendorItems.php - About 1 hr to fix

            Method ajax_callbacks has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function ajax_callbacks($action){
        global $FANNIE_OP_DB;
        switch($action){
        case 'getCategoryBrands':
            $this->getCategoryBrands(FormLib::get_form_Value('vid'),FormLib::get_form_value('deptID'));
            Severity: Minor
            Found in fannie/item/vendors/BrowseVendorItems.php - About 1 hr to fix

              Function body_content has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  function body_content()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        $vid = FormLib::get_form_value('vid');
        if ($vid === ''){
              Severity: Minor
              Found in fannie/item/vendors/BrowseVendorItems.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function guessSuper has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function guessSuper($vid, $did, $brand)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
              Severity: Minor
              Found in fannie/item/vendors/BrowseVendorItems.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method addToPos has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private function addToPos($upc,$vid,$price,$dept,$tags=-1)
              Severity: Minor
              Found in fannie/item/vendors/BrowseVendorItems.php - About 35 mins to fix

                Function showCategoryItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function showCategoryItems($vid,$did,$brand,$ds=-999)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
                Severity: Minor
                Found in fannie/item/vendors/BrowseVendorItems.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    private function getSRP($cost,$margin)
    {
        $srp = sprintf("%.2f",$cost/(1-$margin));
        while (substr($srp,strlen($srp)-1,strlen($srp)) != "5" &&
               substr($srp,strlen($srp)-1,strlen($srp)) != "9")
                Severity: Major
                Found in fannie/item/vendors/BrowseVendorItems.php and 1 other location - About 1 hr to fix
                fannie/item/ajax.php on lines 93..99

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status