Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/vendors/VendorDepartmentEditor.php

Summary

Maintainability
B
5 hrs
Test Coverage
F
25%

Method ajax_callbacks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function ajax_callbacks($action)
    {
        global $FANNIE_OP_DB;
        $json = array('error' => 0);
        switch($action){
Severity: Minor
Found in fannie/item/vendors/VendorDepartmentEditor.php - About 1 hr to fix

    Method rowToTable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function rowToTable($id, $row)
    {
        return sprintf("<tr id=\"row-%d\">
            <td>%d</td>
            <td id=nametd%d>%s</td>
    Severity: Minor
    Found in fannie/item/vendors/VendorDepartmentEditor.php - About 1 hr to fix

      Method body_content has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function body_content()
    {
        $vid = FormLib::get_form_value('vid');
        if ($vid === '') {
            return '<div class="alert alert-danger">Error: no vendor selected</div>';
      Severity: Minor
      Found in fannie/item/vendors/VendorDepartmentEditor.php - About 1 hr to fix

        Method vendorDeptDisplay has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function vendorDeptDisplay($id)
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Minor
        Found in fannie/item/vendors/VendorDepartmentEditor.php - About 1 hr to fix

          Function ajax_callbacks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              function ajax_callbacks($action)
    {
        global $FANNIE_OP_DB;
        $json = array('error' => 0);
        switch($action){
          Severity: Minor
          Found in fannie/item/vendors/VendorDepartmentEditor.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status