Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/AdvancedMemSearch.php

Summary

Maintainability
F
3 days
Test Coverage
B
87%

File AdvancedMemSearch.php has 472 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

include(__DIR__ . '/../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../classlib2.0/FannieAPI.php');
Severity: Minor
Found in fannie/mem/AdvancedMemSearch.php - About 7 hrs to fix

    Method get_view has 124 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_view()
    {
        $memtype = new MemtypeModel($this->connection);
        $memtype = $memtype->toOptions(-999);
        $couponR = $this->connection->query('SELECT coupID, description FROM houseCoupons ORDER BY startDate DESC');
    Severity: Major
    Found in fannie/mem/AdvancedMemSearch.php - About 4 hrs to fix

      Method post_handler has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function post_handler()
    {
        $search = new stdClass();
        $search->args = array();
        $search->where = '1=1 ';
      Severity: Minor
      Found in fannie/mem/AdvancedMemSearch.php - About 1 hr to fix

        Method filterHasShopped has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function filterHasShopped($data, $form)
    {
        if (is_numeric($form->tryGet('hasShopped'))) {
            $start = date('Y-m-d', strtotime($form->hasShopped . ' days ago'));
            $end = date('Y-m-d');
        Severity: Minor
        Found in fannie/mem/AdvancedMemSearch.php - About 1 hr to fix

          Method filterUsedCoupon has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function filterUsedCoupon($data, $form)
    {
        if (is_numeric($form->tryGet('usedCoupon'))) {
            $couponP = $this->connection->prepare("SELECT * FROM houseCoupons WHERE coupID=?");
            $coupon = $this->connection->getRow($couponP, array($form->usedCoupon));
          Severity: Minor
          Found in fannie/mem/AdvancedMemSearch.php - About 1 hr to fix

            Method unitTest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function unitTest($phpunit)
    {
        $phpunit->assertInternalType('string', $this->get_view());
        ob_start();
        $phpunit->assertEquals(false, $this->post_handler());
            Severity: Minor
            Found in fannie/mem/AdvancedMemSearch.php - About 1 hr to fix

              Method filterHasNotShopped has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function filterHasNotShopped($data, $form)
    {
        if (is_numeric($form->tryGet('hasntShopped'))) {
            $start = date('Y-m-d', strtotime($form->hasntShopped . ' days ago'));
            $end = date('Y-m-d');
              Severity: Minor
              Found in fannie/mem/AdvancedMemSearch.php - About 1 hr to fix

                Function filterUsedCoupon has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function filterUsedCoupon($data, $form)
    {
        if (is_numeric($form->tryGet('usedCoupon'))) {
            $couponP = $this->connection->prepare("SELECT * FROM houseCoupons WHERE coupID=?");
            $coupon = $this->connection->getRow($couponP, array($form->usedCoupon));
                Severity: Minor
                Found in fannie/mem/AdvancedMemSearch.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function filterHasShopped has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function filterHasShopped($data, $form)
    {
        if (is_numeric($form->tryGet('hasShopped'))) {
            $start = date('Y-m-d', strtotime($form->hasShopped . ' days ago'));
            $end = date('Y-m-d');
                Severity: Minor
                Found in fannie/mem/AdvancedMemSearch.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function filterHasNotShopped has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function filterHasNotShopped($data, $form)
    {
        if (is_numeric($form->tryGet('hasntShopped'))) {
            $start = date('Y-m-d', strtotime($form->hasntShopped . ' days ago'));
            $end = date('Y-m-d');
                Severity: Minor
                Found in fannie/mem/AdvancedMemSearch.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        if (trim($form->tryGet('addr')) != '') {
            $search = $this->addTable($search, FannieDB::fqn('meminfo', 'op'), 'm', 'card_no');
            $search->where .= ' AND m.street LIKE ? ';
            $search->args[] = '%' . str_replace('*', '%', trim($form->addr)) . '%';
        }
                Severity: Major
                Found in fannie/mem/AdvancedMemSearch.php and 4 other locations - About 1 hr to fix
                fannie/mem/AdvancedMemSearch.php on lines 182..186
                fannie/mem/AdvancedMemSearch.php on lines 198..202
                fannie/mem/AdvancedMemSearch.php on lines 203..207
                fannie/mem/AdvancedMemSearch.php on lines 208..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        if (trim($form->tryGet('state')) != '') {
            $search = $this->addTable($search, FannieDB::fqn('meminfo', 'op'), 'm', 'card_no');
            $search->where .= ' AND m.state LIKE ? ';
            $search->args[] = '%' . str_replace('*', '%', trim($form->state)) . '%';
        }
                Severity: Major
                Found in fannie/mem/AdvancedMemSearch.php and 4 other locations - About 1 hr to fix
                fannie/mem/AdvancedMemSearch.php on lines 182..186
                fannie/mem/AdvancedMemSearch.php on lines 193..197
                fannie/mem/AdvancedMemSearch.php on lines 198..202
                fannie/mem/AdvancedMemSearch.php on lines 208..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        if (trim($form->tryGet('zip')) != '') {
            $search = $this->addTable($search, FannieDB::fqn('meminfo', 'op'), 'm', 'card_no');
            $search->where .= ' AND m.zip LIKE ? ';
            $search->args[] = '%' . str_replace('*', '%', trim($form->zip)) . '%';
        }
                Severity: Major
                Found in fannie/mem/AdvancedMemSearch.php and 4 other locations - About 1 hr to fix
                fannie/mem/AdvancedMemSearch.php on lines 182..186
                fannie/mem/AdvancedMemSearch.php on lines 193..197
                fannie/mem/AdvancedMemSearch.php on lines 198..202
                fannie/mem/AdvancedMemSearch.php on lines 203..207

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        if (trim($form->tryGet('city')) != '') {
            $search = $this->addTable($search, FannieDB::fqn('meminfo', 'op'), 'm', 'card_no');
            $search->where .= ' AND m.city LIKE ? ';
            $search->args[] = '%' . str_replace('*', '%', trim($form->city)) . '%';
        }
                Severity: Major
                Found in fannie/mem/AdvancedMemSearch.php and 4 other locations - About 1 hr to fix
                fannie/mem/AdvancedMemSearch.php on lines 182..186
                fannie/mem/AdvancedMemSearch.php on lines 193..197
                fannie/mem/AdvancedMemSearch.php on lines 203..207
                fannie/mem/AdvancedMemSearch.php on lines 208..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                        if (trim($form->tryGet('email')) != '') {
            $search = $this->addTable($search, FannieDB::fqn('meminfo', 'op'), 'm', 'card_no');
            $search->where .= ' AND m.email_1 LIKE ? ';
            $search->args[] = '%' . str_replace('*', '%', trim($form->email)) . '%';
        }
                Severity: Major
                Found in fannie/mem/AdvancedMemSearch.php and 4 other locations - About 1 hr to fix
                fannie/mem/AdvancedMemSearch.php on lines 193..197
                fannie/mem/AdvancedMemSearch.php on lines 198..202
                fannie/mem/AdvancedMemSearch.php on lines 203..207
                fannie/mem/AdvancedMemSearch.php on lines 208..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status