Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/MemberPreferences.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
41%

Function get_id_handler has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function get_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $cardno = $this->id;
Severity: Minor
Found in fannie/mem/MemberPreferences.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_id_view has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        if ($this->id == 0) {
            return '<div class="alert alert-danger">No member specified</div>';
        }
Severity: Minor
Found in fannie/mem/MemberPreferences.php - About 1 hr to fix

    Method get_id_handler has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_id_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $cardno = $this->id;
    Severity: Minor
    Found in fannie/mem/MemberPreferences.php - About 1 hr to fix

      Function setupNotification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setupNotification($cardno, $val, $notice)
    {
        $ret = true;
        if (filter_var($val, FILTER_VALIDATE_EMAIL)) {
            $notice->reset();
      Severity: Minor
      Found in fannie/mem/MemberPreferences.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status