Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/StatusFromSearch.php

Summary

Maintainability
D
1 day
Test Coverage

Method suspendAccount has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function suspendAccount($id, $account, $cas_model, $code, $status)
    {
        $discount = 0;
        foreach ($account['customers'] as $c) {
            if ($c['accountHolder']) {
Severity: Minor
Found in fannie/mem/StatusFromSearch.php - About 2 hrs to fix

    Function post_view has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function post_view()
    {
        $codes = FormLib::get('rc');
        $code = 0;
        foreach ($codes as $c) {
    Severity: Minor
    Found in fannie/mem/StatusFromSearch.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reSuspendAccount has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function reSuspendAccount($id, $account, $cas_model, $susp, $code, $status)
    {
        $m_status = 0;
        if ($status == 'TERM') {
            $susp->type('T');
    Severity: Minor
    Found in fannie/mem/StatusFromSearch.php - About 1 hr to fix

      Method post_view has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function post_view()
    {
        $codes = FormLib::get('rc');
        $code = 0;
        foreach ($codes as $c) {
      Severity: Minor
      Found in fannie/mem/StatusFromSearch.php - About 1 hr to fix

        Method post_id_view has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function post_id_view()
    {
        $acctList = implode(", ", $this->id);

        $ids = "";
        Severity: Minor
        Found in fannie/mem/StatusFromSearch.php - About 1 hr to fix

          Method activateAccount has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function activateAccount($id, $account, $cas_model)
    {
        // log activation into history
        $history = new SuspensionHistoryModel($this->connection);
        $history->username($this->current_user);
          Severity: Minor
          Found in fannie/mem/StatusFromSearch.php - About 1 hr to fix

            Function reSuspendAccount has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function reSuspendAccount($id, $account, $cas_model, $susp, $code, $status)
    {
        $m_status = 0;
        if ($status == 'TERM') {
            $susp->type('T');
            Severity: Minor
            Found in fannie/mem/StatusFromSearch.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method reSuspendAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function reSuspendAccount($id, $account, $cas_model, $susp, $code, $status)
            Severity: Minor
            Found in fannie/mem/StatusFromSearch.php - About 45 mins to fix

              Method suspendAccount has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private function suspendAccount($id, $account, $cas_model, $code, $status)
              Severity: Minor
              Found in fannie/mem/StatusFromSearch.php - About 35 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        foreach($current as $obj) {
            if ($obj->reasonCode() != $code || $obj->suspensionTypeID() != $m_status) {
                $changed = true;
            }
            $cas_model->savedType($obj->savedType());
                Severity: Major
                Found in fannie/mem/StatusFromSearch.php and 2 other locations - About 1 hr to fix
                fannie/mem/MemStatusEditor.php on lines 177..189
                fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php on lines 358..370

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status