Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/correction_pages/MemEquityTransferTool.php

Summary

Maintainability
D
2 days
Test Coverage
F
33%

Function preprocess has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    function preprocess(){
        global $FANNIE_EQUITY_DEPARTMENTS;
        global $FANNIE_OP_DB;
        global $FANNIE_EMP_NO, $FANNIE_REGISTER_NO;
        global $FANNIE_CORRECTION_DEPT;
Severity: Minor
Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method preprocess has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function preprocess(){
        global $FANNIE_EQUITY_DEPARTMENTS;
        global $FANNIE_OP_DB;
        global $FANNIE_EMP_NO, $FANNIE_REGISTER_NO;
        global $FANNIE_CORRECTION_DEPT;
Severity: Major
Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 4 hrs to fix

    File MemEquityTransferTool.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010,2013 Whole Foods Co-op, Duluth, MN
    Severity: Minor
    Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 2 hrs to fix

      Method finish_content has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function finish_content(){

        if (!empty($this->errors)) return $this->errors;

        $ret = '';
      Severity: Minor
      Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 1 hr to fix

        Method form_content has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function form_content(){

        if (!empty($this->errors)) return $this->errors;

        ob_start();
        Severity: Minor
        Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                          return True;
          Severity: Major
          Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return True;
            Severity: Major
            Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return True;
              Severity: Major
              Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return True;
                Severity: Major
                Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return True;
                  Severity: Major
                  Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return True;
                    Severity: Major
                    Found in fannie/mem/correction_pages/MemEquityTransferTool.php - About 30 mins to fix

                      There are no issues that match your filters.

                      Category
                      Status