Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/correction_pages/PatronageTransferTool.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
39%

Method preprocess has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function preprocess()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $FANNIE_EMP_NO = $this->config->get('EMP_NO');
Severity: Major
Found in fannie/mem/correction_pages/PatronageTransferTool.php - About 2 hrs to fix

    Function preprocess has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        function preprocess()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $FANNIE_EMP_NO = $this->config->get('EMP_NO');
    Severity: Minor
    Found in fannie/mem/correction_pages/PatronageTransferTool.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method finish_content has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function finish_content(){

        if (!empty($this->errors)) return $this->errors;

        $ret = '';
    Severity: Minor
    Found in fannie/mem/correction_pages/PatronageTransferTool.php - About 1 hr to fix

      Method form_content has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function form_content(){

        if (!empty($this->errors)) return $this->errors;

        ob_start();
      Severity: Minor
      Found in fannie/mem/correction_pages/PatronageTransferTool.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status