Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/modules/ContactInfo.php

Summary

Maintainability
C
1 day
Test Coverage
D
64%

Method showEditForm has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function showEditForm($memNum, $country="US")
    {
        $account = self::getAccount();
        $primary = array();
        foreach ($account['customers'] as $c) {
Severity: Major
Found in fannie/mem/modules/ContactInfo.php - About 2 hrs to fix

    Method showSearchForm has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function showSearchForm($country="US")
    {
        $labels = array();
        switch ($country) {
            case "US":
    Severity: Minor
    Found in fannie/mem/modules/ContactInfo.php - About 1 hr to fix

      Method getSearchResults has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function getSearchResults()
    {
        $fn = FormLib::get_form_value('ContactInfo_fn');
        $ln = FormLib::get_form_value('ContactInfo_ln');
        $addr = FormLib::get_form_value('ContactInfo_addr');
      Severity: Minor
      Found in fannie/mem/modules/ContactInfo.php - About 1 hr to fix

        Function getSearchResults has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            function getSearchResults()
    {
        $fn = FormLib::get_form_value('ContactInfo_fn');
        $ln = FormLib::get_form_value('ContactInfo_ln');
        $addr = FormLib::get_form_value('ContactInfo_addr');
        Severity: Minor
        Found in fannie/mem/modules/ContactInfo.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function showEditForm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            function showEditForm($memNum, $country="US")
    {
        $account = self::getAccount();
        $primary = array();
        foreach ($account['customers'] as $c) {
        Severity: Minor
        Found in fannie/mem/modules/ContactInfo.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function saveFormData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function saveFormData($memNum, $json=array())
    {
        $json['addressFirstLine'] = $this->form->tryGet('ContactInfo_addr1');
        $json['addressSecondLine'] = $this->form->tryGet('ContactInfo_addr2');
        $json['city'] = $this->form->tryGet('ContactInfo_city');
        Severity: Minor
        Found in fannie/mem/modules/ContactInfo.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status