Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/mem/patronage/AllocatePatronagePage.php

Summary

Maintainability
B
6 hrs
Test Coverage
F
1%

Method post_handler has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function post_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Major
Found in fannie/mem/patronage/AllocatePatronagePage.php - About 2 hrs to fix

    Method get_view has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_view()
    {
        return '<form method="post">
            ' . $this->message . '
            <div class="form-group">
    Severity: Minor
    Found in fannie/mem/patronage/AllocatePatronagePage.php - About 1 hr to fix

      Method helpContent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function helpContent()
    {
        return '<p>This tool takes the total net purchases for active
            owners in the draft patronage data and allocates the given
            amount to each owner based on their share of total net
      Severity: Minor
      Found in fannie/mem/patronage/AllocatePatronagePage.php - About 1 hr to fix

        Function post_handler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function post_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        Severity: Minor
        Found in fannie/mem/patronage/AllocatePatronagePage.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method insertRecords has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function insertRecords($dbc, $result, $purchases, $paid, $retained, $amount)
        Severity: Minor
        Found in fannie/mem/patronage/AllocatePatronagePage.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status