Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php

Summary

Maintainability
F
1 wk
Test Coverage

Function monthView has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
Open

    public static function monthView($id,$month,$year,$uid)
    {
        global $FANNIE_OP_DB;
        $DAY_NAMES = self::$DAY_NAME_MAPPING;
Severity: Minor
Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File CalendarPluginDisplayLib.php has 579 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
Severity: Major
Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 1 day to fix

    Method monthView has 195 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function monthView($id,$month,$year,$uid)
    {
        global $FANNIE_OP_DB;
        $DAY_NAMES = self::$DAY_NAME_MAPPING;
    Severity: Major
    Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 7 hrs to fix

      Method weekView has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function weekView($id, $year, $week)
    {
        $sql = CalendarPluginDB::get();
        $calendarModel = new CalendarsModel($sql);
        $calendarModel->calendarID($id);
      Severity: Major
      Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 4 hrs to fix

        Function prefsView has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function prefsView($calID,$uid)
    {
        global $FANNIE_OP_DB;
        if (!CalendarPluginPermissions::is_owner($uid,$calID)){
            return "<h2>Either something goofed up or you aren't allowed to change
        Severity: Minor
        Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method indexView has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function indexView($uid)
    {
        global $FANNIE_URL;
        $yours = CalendarPluginPermissions::get_own_calendars($uid);
        $theirs = CalendarPluginPermissions::get_other_calendars($uid);
        Severity: Major
        Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 3 hrs to fix

          Method prefsView has 83 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function prefsView($calID,$uid)
    {
        global $FANNIE_OP_DB;
        if (!CalendarPluginPermissions::is_owner($uid,$calID)){
            return "<h2>Either something goofed up or you aren't allowed to change
          Severity: Major
          Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 3 hrs to fix

            Function weekView has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function weekView($id, $year, $week)
    {
        $sql = CalendarPluginDB::get();
        $calendarModel = new CalendarsModel($sql);
        $calendarModel->calendarID($id);
            Severity: Minor
            Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method showoverlayView has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function showoverlayView($calIDs,$startDate,$endDate){
        $ret = "<body>";

        $sql = CalendarPluginDB::get();
        $ids = "(";
            Severity: Minor
            Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 2 hrs to fix

              Method overlaysView has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function overlaysView($uid){
        $yours = CalendarPluginPermissions::get_own_calendars($uid);
        $theirs = CalendarPluginPermissions::get_other_calendars($uid);

        $ret = "<body>";
              Severity: Minor
              Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 1 hr to fix

                Function showoverlayView has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function showoverlayView($calIDs,$startDate,$endDate){
        $ret = "<body>";

        $sql = CalendarPluginDB::get();
        $ids = "(";
                Severity: Minor
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (isset($db_data[$datestring])) {
                foreach($db_data[$datestring] as $dat) {
                    $datebox .= sprintf("<div class=\"%s\" ",$classes[$c]);
                    $c = ($c+1)%2;
                    if (($EDIT && $uid==$dat['uid']) || $OWNER){
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 1 day to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 193..216

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 277.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (isset($db_data[$datestring])) {
                        foreach($db_data[$datestring] as $dat) {
                            $datebox .= sprintf("<div class=\"%s\" ",$classes[$c]);
                            $c = ($c+1)%2;
                            if (($EDIT && $uid==$dat['uid']) || $OWNER){
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 1 day to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 136..159

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 277.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            for($i=0; $i<7; $i++) {
                $entry_ts = mktime($hour, 0, 0, date('n', $startTS), date('j', $startTS)+$i, date('Y', $startTS));
                if ($EDIT) {
                    $ret .= sprintf('<td id="weekEntry%d" class="weekEntry"
                                    onclick="weekClickCallback(%d);"
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 6 hrs to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 349..373

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 222.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            for($i=0; $i<7; $i++) {
                $entry_ts = mktime($hour, 30, 0, date('n', $startTS), date('j', $startTS)+$i, date('Y', $startTS));
                if ($EDIT) {
                    $ret .= sprintf('<td id="weekEntry%d" class="weekEntry"
                                    onclick="weekClickCallback(%d);"
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 6 hrs to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 321..345

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 222.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        while($viewW = $db->fetch_row($viewR)){
            $name = $userW['real_name'];
            if ($viewW[0] == -1) $name = "Everyone";
            elseif ($name == '') $name = $userW['name'];
            else if ($name == 'Array') $name = $userW['name'];
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 1 hr to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 612..618

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        while($viewW = $db->fetch_row($viewR)){
            $name = $userW['real_name'];
            if ($viewW[0] == -1) $name = "Everyone";
            elseif ($name == '') $name = $userW['name'];
            else if ($name == 'Array') $name = $userW['name'];
                Severity: Major
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 1 hr to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 638..644

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (!$found && $EDIT) {
                $datebox .= "<div class=\"monthview_box\" ";
                if ($EDIT){
                    $datebox .= " onclick=\"add_event('$datestring','$uid')\" ";
                    $datebox .= " ondblclick=\"save_open_event()\" ";
                Severity: Minor
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 40 mins to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 217..227

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (!$found && $EDIT) {
                        $datebox .= "<div class=\"monthview_box\" ";
                        if ($EDIT){
                            $datebox .= " onclick=\"add_event('$datestring','$uid')\" ";
                            $datebox .= " ondblclick=\"save_open_event()\" ";
                Severity: Minor
                Found in fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php and 1 other location - About 40 mins to fix
                fannie/modules/plugins2.0/CalendarPlugin/CalendarPluginDisplayLib.php on lines 160..170

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status